Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the player screen to TV app #1324

Conversation

chikoski
Copy link
Contributor

@chikoski chikoski commented Apr 8, 2024

This pull request adds the player screen to the TV app. In related to that, EpisodePlayer interface is updated so that EpisodePlayer implementations can play the given PlayerEpisode.

@chikoski chikoski requested a review from arriolac April 8, 2024 08:57
@chikoski chikoski requested a review from a team as a code owner April 8, 2024 08:57
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also make sure to indicate in a comment that the player screen is mocked and not actually playing any media.

@arriolac
Copy link
Contributor

arriolac commented Apr 8, 2024

#1326 should fix the build failure

@chikoski chikoski force-pushed the jetcaster/add_play_screen_to_tv branch from 11c63be to 5662615 Compare April 9, 2024 01:11
@chikoski chikoski merged commit 8a6246e into android:jetcaster/all_form_factors Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants