[Jetcaster] Handling of HTML Elements in PodcastSummary on Foldable Devices #1339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated depedencies
Unnecessary state reads for colors, which never change. Following official [M3 color scheme](https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/ColorScheme.kt?q=androidx.compose.material3.ColorScheme)
…avigationBar (android#1323) Fixed Issue : android#1322 
|
Thanks! I'm aware of this issue but I think it would be good to use the new As mentioned in #1338, we have been working on |
@arriolac Done :) |
|
Looks like there are some conflicts. Please address |
…er/html-txt # Conflicts: # Jetcaster/app/src/main/java/com/example/jetcaster/ui/player/PlayerScreen.kt
|
sry, I found the conflicting parts and have made the corrections. 🥲 |
arriolac
reviewed
Apr 12, 2024
Jetcaster/app/src/main/java/com/example/jetcaster/ui/player/PlayerScreen.kt
Show resolved
Hide resolved
arriolac
merged commit 8550dce
into
android:jetcaster/all_form_factors
29 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where the Summary Text does not contain HTML elements. In these instances, it is considered that the performance overhead is negligible, therefore no additional processing was implemented