[Wear] Adds queue screen #1344
Merged
[Wear] Adds queue screen #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kul3r4
force-pushed
the
jetcaster/all_form_factors
branch
from
e7fae32
to
54d97b9
Compare
yschimke
reviewed
Apr 15, 2024
| }, | ||
| onEpisodeItemClick = { navController.navigateToPlayer() }, | ||
| onErrorDialogCancelClick = { | ||
| navController.popBackStack() |
There was a problem hiding this comment.
You can combine these into a single navigation command. with a popUpTo param.
yschimke
reviewed
Apr 15, 2024
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/home/HomeScreen.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Apr 15, 2024
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/library/QueueScreen.kt
Outdated
Show resolved
Hide resolved
yschimke
reviewed
Apr 15, 2024
| if (it.queue.isNotEmpty()) { | ||
| QueueScreenState.Loaded(it.queue) | ||
| } else { | ||
| QueueScreenState.Error |
There was a problem hiding this comment.
Is this actually an error? Or should just be an empty queue?
There was a problem hiding this comment.
renamed to empty. I am using a similar patter to the downloads in the Media Toolkit where you actually do not navigate into the download sections until something is downloaded. So I don't expect the queue to be empty unless there is a failure loadign from the repository.
yschimke
reviewed
Apr 15, 2024
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/library/QueueScreen.kt
Show resolved
Hide resolved
yschimke
approved these changes
Apr 15, 2024
kul3r4
force-pushed
the
jetcaster/all_form_factors
branch
from
54d97b9
to
f2aec6e
Compare
arriolac
approved these changes
Apr 15, 2024
| import com.google.android.horologist.media.ui.screens.entity.DefaultEntityScreenHeader | ||
| import com.google.android.horologist.media.ui.screens.entity.EntityScreen | ||
|
|
||
| @Composable fun QueueScreen( |
There was a problem hiding this comment.
Suggested change
| @Composable fun QueueScreen( | |
| @Composable | |
| fun QueueScreen( |
Jetcaster/wear/src/main/java/com/example/jetcaster/ui/library/QueueScreen.kt
Outdated
Show resolved
Hide resolved
kul3r4
force-pushed
the
jetcaster/all_form_factors
branch
from
f2aec6e
to
b018671
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the queue screen and some refactoring