Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Jetcaster] Add Podcast image loading #1347

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[Jetcaster] Add Podcast image loading #1347

merged 2 commits into from
Apr 17, 2024

Conversation

yongsuk44
Copy link
Contributor

  • Added the PotcastImage component
  • Added a ProgressIndicator when loading images
image_load.webm
@yongsuk44 yongsuk44 requested a review from a team as a code owner April 17, 2024 01:57
@yongsuk44 yongsuk44 requested a review from arriolac April 17, 2024 01:57
arriolac
arriolac reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of adding a component like this to handle loading and errors. You beat me to it! 😀 Just one comment
...ster/designsystem/src/main/java/com/example/jetcaster/designsystem/component/PodcastImage.kt Outdated Show resolved Hide resolved
@arriolac arriolac merged commit 6f2e501 into android:main Apr 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@yongsuk44 @arriolac