Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor UI tweak on Jetcaster/tv-app #1353

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Minor UI tweak on Jetcaster/tv-app #1353

merged 6 commits into from
Apr 22, 2024

Conversation

chikoski
Copy link
Contributor

This pull request aims to polish UI of the Jetcaster TV app. More specifically, the following changes are applied:

  • Switch app icon from default one to the proper Jetcaster icon
  • Set a placeholder for thumbnails in case thumbnail is not available
  • Change the search screen behavior to be consistent with the expected filter chip behavior
@chikoski chikoski requested a review from arriolac April 19, 2024 01:20
@chikoski chikoski requested a review from a team as a code owner April 19, 2024 01:20
arriolac
arriolac approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM. I just have a couple of suggestions on how we can improve reusability across other form factors—image loading behavior specifically seems like something we can share.
Jetcaster/tv-app/src/main/java/com/example/jetcaster/tv/model/CategoryInfoList.kt Outdated Show resolved Hide resolved
Jetcaster/tv-app/src/main/java/com/example/jetcaster/tv/ui/component/EpisodeCard.kt Show resolved Hide resolved
Jetcaster/tv-app/src/main/java/com/example/jetcaster/tv/ui/component/thumbnailPlaceholder.kt Show resolved Hide resolved
@chikoski chikoski merged commit 8f10e6e into android:main Apr 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@chikoski @arriolac