Fix Compose Previews in the Reply sample #1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Temp fix LGTM and is in the spirit of the original code I wrote. |
bentrengrove
approved these changes
Apr 25, 2024
|
Needs a rebase on top of #1364 I think |
|
Just merged #1364. Feel free to rebase against |
amaurymedeiros
force-pushed
the
reply-fix-previews
branch
from
edb217c
to
d41c162
Compare
Currenly, Compose Previews don't support UIModeManager, so any previews using the ContrastAwareReplyTheme will fail to render when trying to apply contrast. While UIModeManager support is not added, we can work around this issue by not adding contrast in Compose Previews.
amaurymedeiros
force-pushed
the
reply-fix-previews
branch
from
d41c162
to
21ba1d0
Compare
|
Rebase is done and checks have passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currenly, Compose Previews don't support UIModeManager, so any previews using the ContrastAwareReplyTheme will fail to render when trying to apply contrast. While UIModeManager support is not added, we can work around this issue by not adding contrast in Compose Previews.