fix(@schematics/angular): add missing express REQUEST and RESPONSE tokens

[alan-agius4]

This commit updates the nguniversal migration to add REQUEST and RESPONSE tokens.

Closes #26110

[pavankjadda]

@alan-agius4 Whats the new package that exports these? I just ran the ng update @angular/core @angular/cli --next --force and it didn't update imports.

[pavankjadda]

@alan-agius4 did you get a chance to look at this?

[alan-agius4]

The tokens are no longer exporting from a package. Instead the migration will create them in the project when encountering imports to @nguniversal/express-engine/tokens.

[pavankjadda]

The tokens are no longer exporting from a package. Instead the migration will create them in the project when encountering imports to @nguniversal/express-engine/tokens.

Thanks. I was expecting that after looking at PR.

1. But it's not creating them during migration
2. When I create them manually, I see error

 error TS2742: The inferred type of 'REQUEST' cannot be named without a reference to '.pnpm/@types+express-serve-static-core@4.17.35/node_modules/@types/express-serve-static-core'. This is likely not portable. A type annotation is necessary.

export const REQUEST = new InjectionToken<Request>('REQUEST');

You can run the migration on here https://github.com/stevermeister/ngx-cookie-service and reproduce the issue

[alan-agius4]

Are you importing the Request from the right place?

import { InjectionToken } from '@angular/core';
import { Request, Response } from 'express';

export const REQUEST = new InjectionToken<Request>('REQUEST');
export const RESPONSE = new InjectionToken<Response>('RESPONSE');

[pavankjadda]

Are you importing the Request from the right place?

import { InjectionToken } from '@angular/core';
import { Request, Response } from 'express';

export const REQUEST = new InjectionToken<Request>('REQUEST');
export const RESPONSE = new InjectionToken<Response>('RESPONSE');

I think so. You can see them here https://github.com/stevermeister/ngx-cookie-service/blob/test/projects/ngx-cookie-service-ssr/src/lib/ssr-cookie.service.ts

[pavankjadda]

Are you importing the Request from the right place?

import { InjectionToken } from '@angular/core';
import { Request, Response } from 'express';

export const REQUEST = new InjectionToken<Request>('REQUEST');
export const RESPONSE = new InjectionToken<Response>('RESPONSE');

I think so. You can see them here https://github.com/stevermeister/ngx-cookie-service/blob/test/projects/ngx-cookie-service-ssr/src/lib/ssr-cookie.service.ts

It seems like an issue with PNPM. When I tried with NPM I don't see an issue. But PNPM gives that error. Any idea why?

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}