Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/build): Providing a DI token to dev server for SSR #27803

Closed
wants to merge 1 commit into from

Conversation

klerick
Copy link

@klerick klerick commented Jun 8, 2024

Add configuration for add custom DI token.

issue: #26323

PR Checklist

Please check to confirm your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Add configuration for using custom function for use custom DI token for SSR dev server

Issue Number: 26323

What is the new behavior?

extends angular.json

"ssr": {
          "entry": "path/to/server.ts",
          "providers": "path/to/server-providers.ts"
        },

server-providers.ts

import { REQUEST, RESPONSE } from '@ui-libs/providers';
import { Request, Response } from 'express';

export default (req: Request, res: Response) => [
  {
    provide: REQUEST,
    useValue: req,
  },
  { 
  provide: RESPONSE, 
  useValue: res 
  },
];

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Add configuration for add custom DI token.

issue: angular#26323
Copy link

google-cla bot commented Jun 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@alan-agius4
Copy link
Collaborator

Thanks for your contribution however this implementation does not align the long-term architecture.

We are currently working on a design to solve this problem.

@alan-agius4 alan-agius4 closed this Jun 8, 2024
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants