Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cdkTextareaAutosize: emit event when the textarea height changes #10472

Open
fxck opened this issue Mar 19, 2018 · 2 comments
Open

cdkTextareaAutosize: emit event when the textarea height changes #10472

fxck opened this issue Mar 19, 2018 · 2 comments
Labels
area: cdk/text-field help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion

Comments

@fxck
Copy link
Contributor

fxck commented Mar 19, 2018

It would be more efficient than checking on every keyup of the area.
fxck added a commit to fxck/material2 that referenced this issue Mar 19, 2018
@fxck
feat(cdkTextareaAutosize): emit event when textarea height changes
98a302a 
fixes angular#10472

emit an event when height of the area changes
@fxck fxck mentioned this issue Mar 19, 2018
Closed
@fxck fxck changed the title cdkTextareaAutosize Output for when the size changes Mar 19, 2018
@mmalerba mmalerba added needs triage This issue needs to be triaged by the team P5 The team acknowledges the request but does not plan to address it, it remains open for discussion help wanted The team would appreciate a PR from the community to address this issue and removed has pr needs triage This issue needs to be triaged by the team labels May 20, 2020
@mmalerba
Copy link
Contributor

This isn't a high priority for the team, but I'll accept a PR if someone wants to work on it
@KyleO249
Copy link

KyleO249 commented Mar 4, 2024 •
edited
Loading

Hello, I can try my hand at this PR if it is still available to be worked on. This would be my first contribution so I might be missing a few pointers here and there. Would this apply only to height changes or dimension changes of any kind?

Edited: Nevermind, I see that the directive applies only to height value changes
KyleO249 added a commit to KyleO249/angular-components that referenced this issue Apr 8, 2024
@KyleO249
feat(material/input): add resize event onto cdkTextareaAutosize direc…
5c0d9a1 
…tive

Add a resize event called cdkResize onto the cdkTextareaAutosize to allow event listeners on the textarea component that have the cdkTextareaAutosize to listen out for height changes to said component

Fixes angular#10472
KyleO249 added a commit to KyleO249/angular-components that referenced this issue Apr 8, 2024
@KyleO249
test(material/input): add resize event test onto cdkTextareaAutosize …
1f71ff1 
…directive

Added unit test to ensure the resize event emitter fires as expected

Fixes angular#10472
KyleO249 added a commit to KyleO249/angular-components that referenced this issue Apr 8, 2024
@KyleO249
test(material/input): add resize event demo
6b3ab1c 
Added input demo for resize event

Fixes angular#10472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: cdk/text-field help wanted The team would appreciate a PR from the community to address this issue P5 The team acknowledges the request but does not plan to address it, it remains open for discussion
4 participants
@fxck @crisbeto @mmalerba @KyleO249