Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](multi-catalog)remove http scheme in oss endpoint #34907

Merged
merged 1 commit into from
May 17, 2024

Conversation

wsjz
Copy link
Contributor

@wsjz wsjz commented May 15, 2024

Proposed changes

remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client

p2 case (test_cloud_accessible_oss.groovy) :

CREATE CATALOG  dlf
PROPERTIES (
    "type"="hms",
    "hive.metastore.type" = "dlf",
    "dlf.endpoint" = "dlf.cn-beijing.aliyuncs.com",
    "dlf.region" = "cn-beijing",
    "dlf.proxy.mode" = "DLF_ONLY",
    "dlf.uid" = "xx",
    "dlf.access_key" = "",
    "dlf.secret_key" = "",
    "dlf.access.public" = "true"
);

use jz_datalake;

select * from web_site where web_site_id='AAAAAAAAKBAAAAAA' order by web_site_sk,web_site_id limit 1;

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
Copy link
Contributor

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 17, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@morningman morningman merged commit db34ad5 into apache:master May 17, 2024
26 of 28 checks passed
yiguolei pushed a commit that referenced this pull request May 18, 2024
remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client
dataroaring pushed a commit that referenced this pull request May 26, 2024
remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client
wsjz added a commit to wsjz/incubator-doris that referenced this pull request May 28, 2024
remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client

(cherry picked from commit db34ad5)
wsjz added a commit to wsjz/incubator-doris that referenced this pull request May 28, 2024
remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client

(cherry picked from commit db34ad5)
wsjz added a commit to wsjz/incubator-doris that referenced this pull request May 28, 2024
remove http scheme in oss endpoint, scheme maybe appear in url (http://bucket.http//.region.aliyuncs.com) if use http client

(cherry picked from commit db34ad5)
@morningman morningman mentioned this pull request Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 participants