[Fix](tvf) Fix that tvf reading empty files in compressed formats. #34926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40153 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 187624 ms |
ClickBench: Total hot run time: 30.38 s |
|
run p0 |
morningman
reviewed
May 16, 2024
| @@ -484,7 +484,8 @@ private PFetchTableSchemaRequest getFetchTableStructureRequest() throws TExcepti | |||
| // get first file, used to parse table schema | |||
| TBrokerFileStatus firstFile = null; | |||
| for (TBrokerFileStatus fileStatus : fileStatuses) { | |||
| if (fileStatus.isIsDir() || fileStatus.size == 0) { | |||
| if (fileStatus.isIsDir() || fileStatus.size == 0 | |||
| || (compressionType != TFileCompressType.UNKNOWN && fileStatus.size <= 4)) { | |||
There was a problem hiding this comment.
Are you sure all compressed file size have at least 4 bytes?
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
|
run p0 |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
github-actions
bot
removed
the
approved
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
zddr
approved these changes
May 21, 2024
yiguolei
pushed a commit
that referenced
this pull request
May 21, 2024
…34926) 1. Fix the issue with tvf reading empty compressed files. 2. move two test cases (`test_local_tvf_compression` and `test_s3_tvf_compression`) from p2 to p0
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
May 21, 2024
…pache#34926) 1. Fix the issue with tvf reading empty compressed files. 2. move two test cases (`test_local_tvf_compression` and `test_s3_tvf_compression`) from p2 to p0
BePPPower
added a commit
to BePPPower/doris
that referenced
this pull request
May 21, 2024
…pache#34926) 1. Fix the issue with tvf reading empty compressed files. 2. move two test cases (`test_local_tvf_compression` and `test_s3_tvf_compression`) from p2 to p0
This was referenced May 21, 2024
morningman
pushed a commit
to BePPPower/doris
that referenced
this pull request
May 22, 2024
…pache#34926) 1. Fix the issue with tvf reading empty compressed files. 2. move two test cases (`test_local_tvf_compression` and `test_s3_tvf_compression`) from p2 to p0
morningman
pushed a commit
that referenced
this pull request
May 22, 2024
dataroaring
pushed a commit
that referenced
this pull request
May 26, 2024
…34926) 1. Fix the issue with tvf reading empty compressed files. 2. move two test cases (`test_local_tvf_compression` and `test_s3_tvf_compression`) from p2 to p0
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Fix the issue with tvf reading empty compressed files.
move two test cases (
test_local_tvf_compressionandtest_s3_tvf_compression) from p2 to p0docs: apache/doris-website#654
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...