[fix](nereids)AdjustNullable rule should handle union node with no children #35074
+59
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
starocean999
force-pushed
the
nereids_1020
branch
from
689bc3b
to
d9a04c9
Compare
|
run buildall |
TPC-H: Total hot run time: 40353 ms |
TPC-DS: Total hot run time: 181671 ms |
ClickBench: Total hot run time: 30.64 s |
morrySnow
reviewed
May 22, 2024
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/AdjustNullable.java
Show resolved
Hide resolved
starocean999
force-pushed
the
nereids_1020
branch
from
d9a04c9
to
3067d1f
Compare
|
run buildall |
morrySnow
previously approved these changes
May 23, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40252 ms |
TPC-DS: Total hot run time: 169070 ms |
ClickBench: Total hot run time: 30.57 s |
englefly
reviewed
May 23, 2024
| } | ||
| if (setOperation instanceof LogicalUnion) { | ||
| LogicalUnion logicalUnion = (LogicalUnion) setOperation; | ||
| int consExprListSize = logicalUnion.getConstantExprsList().size(); | ||
| if (consExprListSize > 0 && inputNullable == null) { |
There was a problem hiding this comment.
!logicalUnion.getConstantExprsList().isEmpty() && !setOperation.children().isEmpty()
| } | ||
| } | ||
| } | ||
| if (inputNullable == null) { |
There was a problem hiding this comment.
logicalUnion.getConstantExprsList().isEmpty() && setOperation.children().isEmpty()
=> inputNullable == null
starocean999
force-pushed
the
nereids_1020
branch
from
3067d1f
to
6bf6420
Compare
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 39882 ms |
TPC-DS: Total hot run time: 169486 ms |
ClickBench: Total hot run time: 30.72 s |
starocean999
force-pushed
the
nereids_1020
branch
from
6bf6420
to
a788620
Compare
|
run buildall |
TPC-H: Total hot run time: 40581 ms |
TPC-DS: Total hot run time: 169240 ms |
ClickBench: Total hot run time: 30.38 s |
|
run buildall |
morrySnow
approved these changes
May 24, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
TPC-H: Total hot run time: 41160 ms |
TPC-DS: Total hot run time: 169796 ms |
ClickBench: Total hot run time: 29.98 s |
englefly
approved these changes
May 24, 2024
yiguolei
pushed a commit
that referenced
this pull request
May 24, 2024
…hildren (#35074) The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info byboth children and constantExprList.
xiaokang
pushed a commit
that referenced
this pull request
May 26, 2024
dataroaring
pushed a commit
that referenced
this pull request
May 26, 2024
…hildren (#35074) The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info byboth children and constantExprList.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
May 27, 2024
…hildren (apache#35074) The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info byboth children and constantExprList.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The output slot's nullable info is not correctly calculated in union node. Because old code only get correct result if union node has children. But the union node may have no children but only have constantExprList. So in that case, we should calculate output's nullable info by both children and constantExprList.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...