[fix](paimon)fix paimon cache bug #35309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
3 tasks
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 40968 ms |
TPC-DS: Total hot run time: 170714 ms |
ClickBench: Total hot run time: 31.06 s |
morningman
reviewed
May 24, 2024
...e-java-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonJniScanner.java
Outdated
Show resolved
Hide resolved
…doris/paimon/PaimonJniScanner.java Co-authored-by: Mingyu Chen <morningman.cmy@gmail.com>
|
run buildall |
TPC-H: Total hot run time: 41282 ms |
TPC-DS: Total hot run time: 172678 ms |
ClickBench: Total hot run time: 30.3 s |
|
run buildall |
TPC-H: Total hot run time: 41334 ms |
TPC-DS: Total hot run time: 171208 ms |
ClickBench: Total hot run time: 30.12 s |
|
run buildall |
TPC-H: Total hot run time: 41245 ms |
TPC-DS: Total hot run time: 172718 ms |
ClickBench: Total hot run time: 31.47 s |
|
run buildall |
TPC-H: Total hot run time: 41620 ms |
TPC-DS: Total hot run time: 170924 ms |
ClickBench: Total hot run time: 29.98 s |
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
|
PR approved by anyone and no changes requested. |
wuwenchi
approved these changes
May 27, 2024
yiguolei
pushed a commit
that referenced
this pull request
May 28, 2024
Issue Number: close #35024 This bug is because the fe incorrectly sets the update time of paimon catalog, causing the be to be unable to update paimon's schema in time. ```c++ private void initTable() { PaimonTableCacheKey key = new PaimonTableCacheKey(ctlId, dbId, tblId, paimonOptionParams, dbName, tblName); TableExt tableExt = PaimonTableCache.getTable(key); if (tableExt.getCreateTime() < lastUpdateTime) { LOG.warn("invalidate cache table:{}, localTime:{}, remoteTime:{}", key, tableExt.getCreateTime(), lastUpdateTime); PaimonTableCache.invalidateTableCache(key); tableExt = PaimonTableCache.getTable(key); } this.table = tableExt.getTable(); paimonAllFieldNames = PaimonScannerUtils.fieldNames(this.table.rowType()); if (LOG.isDebugEnabled()) { LOG.debug("paimonAllFieldNames:{}", paimonAllFieldNames); } } ```
dataroaring
pushed a commit
that referenced
this pull request
May 31, 2024
Issue Number: close #35024 This bug is because the fe incorrectly sets the update time of paimon catalog, causing the be to be unable to update paimon's schema in time. ```c++ private void initTable() { PaimonTableCacheKey key = new PaimonTableCacheKey(ctlId, dbId, tblId, paimonOptionParams, dbName, tblName); TableExt tableExt = PaimonTableCache.getTable(key); if (tableExt.getCreateTime() < lastUpdateTime) { LOG.warn("invalidate cache table:{}, localTime:{}, remoteTime:{}", key, tableExt.getCreateTime(), lastUpdateTime); PaimonTableCache.invalidateTableCache(key); tableExt = PaimonTableCache.getTable(key); } this.table = tableExt.getTable(); paimonAllFieldNames = PaimonScannerUtils.fieldNames(this.table.rowType()); if (LOG.isDebugEnabled()) { LOG.debug("paimonAllFieldNames:{}", paimonAllFieldNames); } } ```
This was referenced Jun 1, 2024
Closed
morningman
pushed a commit
that referenced
this pull request
Jun 13, 2024
## Proposed changes Introduced from #35309 `fields.length` indicates the fields we want to read. If a table has 10 fields, but we only select a few fields, then the length of `fields.length` will definitely be less than 10. So the judgment condition here should be greater than.
dataroaring
pushed a commit
that referenced
this pull request
Jun 17, 2024
## Proposed changes Introduced from #35309 `fields.length` indicates the fields we want to read. If a table has 10 fields, but we only select a few fields, then the length of `fields.length` will definitely be less than 10. So the judgment condition here should be greater than.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #35024
This bug is because the fe incorrectly sets the update time of paimon catalog, causing the be to be unable to update paimon's schema in time.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...