Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) fix ShowProcedureStatusCommand sendResultSet #35350

Merged
merged 2 commits into from
May 25, 2024
Merged

[fix](Nereids) fix ShowProcedureStatusCommand sendResultSet #35350

merged 2 commits into from
May 25, 2024

Conversation

zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented May 24, 2024 •
edited
Loading

Proposed changes

Issue Number: close #xxx

Show Command should return an empty Set even if the result is empty

Fix compatible problem with mysql workbench

before repair

Doris > SHOW PROCEDURE STATUS WHERE Db='test';
Query OK, 0 rows affected (0.00 sec)

After repair:

Doris > SHOW PROCEDURE STATUS WHERE Db='test';
Empty set (0.11 sec)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.
morningman
morningman previously approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@morningman
Copy link
Contributor

run buildall
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.
@zy-kkk
Copy link
Member Author

zy-kkk commented May 24, 2024

run buildall
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 24, 2024
@yiguolei yiguolei added the usercase Important user case type label label May 24, 2024
@zy-kkk zy-kkk mentioned this pull request May 24, 2024
Merged
morningman
morningman approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@morningman
Copy link
Contributor

@Vallishp PTAL
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 24, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.
@doris-robot
Copy link

TPC-H: Total hot run time: 41063 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 62879197d615728b84866a1b0127f0a41c66187a, data reload: false

------ Round 1 ----------------------------------
q1	17627	4289	4249	4249
q2	2028	197	197	197
q3	10448	1262	1189	1189
q4	10189	865	838	838
q5	7493	2652	2655	2652
q6	218	138	138	138
q7	945	632	623	623
q8	9214	2147	2106	2106
q9	9379	6631	6691	6631
q10	9166	3842	3849	3842
q11	440	235	225	225
q12	479	231	225	225
q13	18487	3241	3145	3145
q14	257	227	215	215
q15	519	490	472	472
q16	533	413	391	391
q17	975	695	724	695
q18	8431	7857	7821	7821
q19	3375	1573	1489	1489
q20	649	330	313	313
q21	5206	3959	3336	3336
q22	348	291	271	271
Total cold run time: 116406 ms
Total hot run time: 41063 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4518	4456	4511	4456
q2	375	280	265	265
q3	3213	2869	2913	2869
q4	2051	1669	1635	1635
q5	5291	5508	5486	5486
q6	217	129	133	129
q7	2183	1878	1786	1786
q8	3183	3410	3410	3410
q9	8609	8586	8632	8586
q10	4060	3743	3711	3711
q11	582	483	484	483
q12	786	623	627	623
q13	15796	3117	3142	3117
q14	296	280	264	264
q15	524	483	478	478
q16	486	426	446	426
q17	1820	1554	1520	1520
q18	7841	7515	7409	7409
q19	1686	1601	1565	1565
q20	1992	1781	1780	1780
q21	8607	4789	4767	4767
q22	579	486	474	474
Total cold run time: 74695 ms
Total hot run time: 55239 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 169803 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 62879197d615728b84866a1b0127f0a41c66187a, data reload: false

query1	923	374	366	366
query2	6445	2445	2317	2317
query3	6649	205	203	203
query4	20645	17465	17323	17323
query5	4123	415	401	401
query6	237	169	148	148
query7	4596	295	302	295
query8	236	184	183	183
query9	8570	2393	2407	2393
query10	453	280	270	270
query11	10433	10086	10089	10086
query12	138	87	87	87
query13	1637	356	363	356
query14	8871	7544	7480	7480
query15	212	170	173	170
query16	7900	255	250	250
query17	1750	517	511	511
query18	2046	271	263	263
query19	195	166	148	148
query20	95	81	80	80
query21	191	129	131	129
query22	4258	4037	4035	4035
query23	33426	33003	33105	33003
query24	10621	2782	2917	2782
query25	564	356	360	356
query26	700	153	165	153
query27	2183	318	319	318
query28	5790	2058	2096	2058
query29	849	601	590	590
query30	264	185	174	174
query31	968	762	722	722
query32	90	54	51	51
query33	754	265	253	253
query34	1040	483	486	483
query35	691	588	603	588
query36	1076	932	919	919
query37	109	72	73	72
query38	2887	2796	2749	2749
query39	841	772	782	772
query40	202	128	125	125
query41	48	45	45	45
query42	105	94	100	94
query43	581	556	546	546
query44	1247	734	753	734
query45	179	172	176	172
query46	1072	759	696	696
query47	1833	1734	1753	1734
query48	368	298	299	298
query49	857	389	385	385
query50	773	389	386	386
query51	6746	6597	6582	6582
query52	99	90	88	88
query53	353	291	288	288
query54	921	427	424	424
query55	76	74	75	74
query56	272	257	259	257
query57	1105	1029	1044	1029
query58	229	213	214	213
query59	3322	3212	3187	3187
query60	293	263	256	256
query61	109	108	107	107
query62	647	488	439	439
query63	320	283	288	283
query64	8584	2327	1846	1846
query65	3160	3071	3098	3071
query66	780	326	321	321
query67	15356	14767	14856	14767
query68	6066	548	553	548
query69	516	274	266	266
query70	1132	1159	1131	1131
query71	447	267	263	263
query72	8398	5343	2676	2676
query73	761	322	317	317
query74	6042	5511	5585	5511
query75	3689	2626	2660	2626
query76	3448	1019	1037	1019
query77	590	262	264	262
query78	10615	9751	9643	9643
query79	4233	513	518	513
query80	1959	439	433	433
query81	552	258	244	244
query82	1527	93	102	93
query83	296	171	173	171
query84	264	88	84	84
query85	1432	267	262	262
query86	466	314	319	314
query87	3290	3094	3081	3081
query88	4615	2347	2353	2347
query89	499	390	384	384
query90	1980	185	178	178
query91	125	145	93	93
query92	57	46	48	46
query93	5266	509	509	509
query94	1188	179	177	177
query95	397	300	303	300
query96	612	267	262	262
query97	3163	3030	3000	3000
query98	250	223	209	209
query99	1224	857	857	857
Total cold run time: 278192 ms
Total hot run time: 169803 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 29.91 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 62879197d615728b84866a1b0127f0a41c66187a, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.05	0.06
query4	1.67	0.08	0.08
query5	0.55	0.50	0.49
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.53	0.49	0.48
query10	0.53	0.56	0.53
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.60	0.59
query14	0.77	0.76	0.76
query15	0.82	0.80	0.80
query16	0.37	0.37	0.37
query17	0.95	0.96	0.96
query18	0.20	0.25	0.24
query19	1.84	1.68	1.72
query20	0.01	0.02	0.01
query21	15.53	0.68	0.65
query22	4.03	8.11	1.44
query23	18.31	1.39	1.20
query24	1.87	0.22	0.20
query25	0.14	0.09	0.08
query26	0.26	0.16	0.16
query27	0.08	0.08	0.09
query28	13.40	1.01	0.99
query29	13.29	3.34	3.27
query30	0.25	0.05	0.05
query31	2.87	0.40	0.42
query32	3.23	0.46	0.46
query33	2.83	2.96	2.85
query34	17.10	4.40	4.42
query35	4.50	4.51	4.48
query36	0.70	0.48	0.48
query37	0.19	0.15	0.16
query38	0.15	0.15	0.15
query39	0.04	0.04	0.04
query40	0.16	0.14	0.17
query41	0.09	0.05	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.78 s
Total hot run time: 29.91 s
Vallishp
Vallishp approved these changes May 24, 2024
View reviewed changes
Copy link
Contributor

@Vallishp Vallishp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@zy-kkk
Copy link
Member Author

zy-kkk commented May 24, 2024

run buildall
@doris-robot
Copy link

TPC-H: Total hot run time: 41616 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 62879197d615728b84866a1b0127f0a41c66187a, data reload: false

------ Round 1 ----------------------------------
q1	17614	4377	4239	4239
q2	2012	192	201	192
q3	10457	1234	1250	1234
q4	10202	872	813	813
q5	7463	2688	2690	2688
q6	218	135	133	133
q7	968	595	622	595
q8	9243	2114	2096	2096
q9	9132	6712	6634	6634
q10	9109	3800	3910	3800
q11	462	236	239	236
q12	462	212	219	212
q13	17219	3318	3248	3248
q14	266	219	215	215
q15	523	486	475	475
q16	531	405	396	396
q17	971	678	707	678
q18	8389	7853	7686	7686
q19	6262	1553	1512	1512
q20	655	317	337	317
q21	5043	3942	4147	3942
q22	359	275	282	275
Total cold run time: 117560 ms
Total hot run time: 41616 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4471	4432	4414	4414
q2	373	265	277	265
q3	3107	2849	2844	2844
q4	1999	1648	1580	1580
q5	5298	5446	5439	5439
q6	209	120	124	120
q7	2184	1821	1812	1812
q8	3163	3405	3426	3405
q9	8605	8592	8704	8592
q10	4083	3752	3725	3725
q11	589	485	501	485
q12	781	617	625	617
q13	16780	3127	3174	3127
q14	288	271	271	271
q15	523	484	475	475
q16	494	425	441	425
q17	1816	1525	1509	1509
q18	7909	7612	7355	7355
q19	1637	1540	1532	1532
q20	1978	1771	1809	1771
q21	7777	4764	4670	4670
q22	568	508	481	481
Total cold run time: 74632 ms
Total hot run time: 54914 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 167408 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 62879197d615728b84866a1b0127f0a41c66187a, data reload: false

query1	919	386	358	358
query2	6464	2451	2269	2269
query3	6646	207	206	206
query4	19342	17504	17332	17332
query5	4109	413	409	409
query6	244	155	153	153
query7	4587	293	282	282
query8	237	187	176	176
query9	8428	2372	2380	2372
query10	450	270	257	257
query11	10667	10307	10280	10280
query12	132	89	87	87
query13	1640	374	360	360
query14	9246	5872	6660	5872
query15	206	165	167	165
query16	7746	257	250	250
query17	1315	506	508	506
query18	1947	273	261	261
query19	205	147	158	147
query20	91	85	87	85
query21	192	125	128	125
query22	4227	4047	4080	4047
query23	34030	32924	32843	32843
query24	11035	2910	2793	2793
query25	568	350	356	350
query26	702	149	152	149
query27	2265	312	328	312
query28	5769	2056	2084	2056
query29	852	592	590	590
query30	260	175	173	173
query31	981	768	752	752
query32	95	52	57	52
query33	654	289	257	257
query34	860	461	467	461
query35	715	588	585	585
query36	1095	898	890	890
query37	106	68	79	68
query38	2908	2786	2793	2786
query39	853	789	802	789
query40	195	123	123	123
query41	42	42	43	42
query42	104	97	94	94
query43	563	522	540	522
query44	1084	727	751	727
query45	177	158	162	158
query46	1053	716	688	688
query47	1882	1775	1770	1770
query48	357	297	285	285
query49	845	373	377	373
query50	752	383	376	376
query51	6778	6539	6533	6533
query52	100	92	86	86
query53	348	288	279	279
query54	902	432	428	428
query55	71	71	69	69
query56	251	231	234	231
query57	1128	1066	1020	1020
query58	236	201	205	201
query59	3255	3056	3061	3056
query60	267	249	273	249
query61	101	92	88	88
query62	615	446	449	446
query63	304	279	278	278
query64	8524	2202	1678	1678
query65	3147	3064	3141	3064
query66	775	328	321	321
query67	15284	14810	14643	14643
query68	4893	537	530	530
query69	493	261	258	258
query70	1135	1146	1105	1105
query71	419	272	276	272
query72	8207	2695	2556	2556
query73	759	325	312	312
query74	6042	5579	5616	5579
query75	3544	2623	2629	2623
query76	3290	1017	975	975
query77	590	262	261	261
query78	10138	9731	9730	9730
query79	1798	506	512	506
query80	879	436	431	431
query81	531	243	237	237
query82	937	91	89	89
query83	234	164	172	164
query84	246	84	80	80
query85	1430	260	275	260
query86	467	305	320	305
query87	3292	3155	3136	3136
query88	4303	2343	2316	2316
query89	466	382	372	372
query90	1996	185	177	177
query91	119	95	95	95
query92	54	48	52	48
query93	2151	514	503	503
query94	1216	178	179	178
query95	394	299	303	299
query96	589	266	263	263
query97	3137	2966	2972	2966
query98	233	209	217	209
query99	1157	840	858	840
Total cold run time: 267067 ms
Total hot run time: 167408 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 30.16 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 62879197d615728b84866a1b0127f0a41c66187a, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.05
query3	0.23	0.05	0.04
query4	1.68	0.07	0.07
query5	0.50	0.49	0.50
query6	1.12	0.73	0.70
query7	0.01	0.01	0.02
query8	0.05	0.05	0.04
query9	0.54	0.49	0.49
query10	0.55	0.54	0.54
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.60	0.58	0.60
query14	0.76	0.78	0.77
query15	0.82	0.82	0.80
query16	0.35	0.37	0.37
query17	1.00	0.96	1.01
query18	0.23	0.25	0.24
query19	1.81	1.72	1.68
query20	0.01	0.02	0.01
query21	15.46	0.72	0.67
query22	4.57	7.16	1.62
query23	18.27	1.32	1.26
query24	2.01	0.22	0.20
query25	0.13	0.08	0.08
query26	0.29	0.17	0.17
query27	0.09	0.07	0.08
query28	13.28	1.00	0.98
query29	13.25	3.29	3.29
query30	0.24	0.06	0.05
query31	2.86	0.37	0.38
query32	3.38	0.45	0.46
query33	2.88	2.97	2.89
query34	17.29	4.46	4.42
query35	4.49	4.50	4.66
query36	0.63	0.46	0.46
query37	0.17	0.15	0.16
query38	0.15	0.14	0.14
query39	0.04	0.03	0.04
query40	0.17	0.15	0.15
query41	0.09	0.05	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.03
Total cold run time: 110.5 s
Total hot run time: 30.16 s
@yiguolei yiguolei merged commit 5660825 into apache:master May 25, 2024
29 of 31 checks passed
@zy-kkk zy-kkk deleted the fix_mysql_connect branch May 25, 2024 08:41
@zy-kkk zy-kkk removed the dev/2.1.x label May 25, 2024
@Vallishp Vallishp mentioned this pull request May 25, 2024
Merged
dataroaring pushed a commit that referenced this pull request May 26, 2024
@zy-kkk @dataroaring
[fix](Nereids) fix ShowProcedureStatusCommand sendResultSet (#35350)
175e175 
* [fix](Nereids) fix ShowProcedureStatusCommand sendResultSet

* ShowCreateProcedureCommand
seawinde pushed a commit to seawinde/doris that referenced this pull request May 27, 2024
@zy-kkk @seawinde
[fix](Nereids) fix ShowProcedureStatusCommand sendResultSet (apache#3…
91b2362 
…5350)

* [fix](Nereids) fix ShowProcedureStatusCommand sendResultSet

* ShowCreateProcedureCommand
@morningman morningman mentioned this pull request Jun 1, 2024
Closed
zy-kkk pushed a commit that referenced this pull request Jun 2, 2024
@Vallishp
[regression](show stmt) Add test checkpoint for the Show Procedure st…
8cae084 
…atus and Show create procedure command (#35395)

improve regression check point for bug #35350

Added EmptySet checkpoint for SHOW PROCEDURE STATUS and SHOW CREATE PROCEDURE commands.

If empty set return the result in groovy check point will be empty. 
if return OK query, the result will contains [0]
added empty check for result for cases where both command return 0 rows.
dataroaring pushed a commit that referenced this pull request Jun 4, 2024
@Vallishp @dataroaring
[regression](show stmt) Add test checkpoint for the Show Procedure st…
b176a67 
…atus and Show create procedure command (#35395)

improve regression check point for bug #35350

Added EmptySet checkpoint for SHOW PROCEDURE STATUS and SHOW CREATE PROCEDURE commands.

If empty set return the result in groovy check point will be empty. 
if return OK query, the result will contains [0]
added empty check for result for cases where both command return 0 rows.
seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
@Vallishp @seawinde
[regression](show stmt) Add test checkpoint for the Show Procedure st…
5aca682 
…atus and Show create procedure command (apache#35395)

improve regression check point for bug apache#35350

Added EmptySet checkpoint for SHOW PROCEDURE STATUS and SHOW CREATE PROCEDURE commands.

If empty set return the result in groovy check point will be empty. 
if return OK query, the result will contains [0]
added empty check for result for cases where both command return 0 rows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged reviewed usercase Important user case type label
6 participants
@zy-kkk @doris-robot @morningman @Vallishp @gavinchou @yiguolei