-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](catalog) close connection on refresh #35426
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
TPC-H: Total hot run time: 41591 ms
|
TPC-DS: Total hot run time: 169193 ms
|
ClickBench: Total hot run time: 30.62 s
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't we keep it for use next time we refresh the data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Sounds reasonable, I will try refactor it. |
run buildall |
TPC-H: Total hot run time: 41996 ms
|
TPC-DS: Total hot run time: 172903 ms
|
ClickBench: Total hot run time: 31 s
|
PR approved by at least one committer and no changes requested. |
1. When refresh the catalog, the related client(such as HMSClient) should be closed, or the connection may be leaked. 2. Remove some unused code related to deprecated hive external table
1. When refresh the catalog, the related client(such as HMSClient) should be closed, or the connection may be leaked. 2. Remove some unused code related to deprecated hive external table
1. When refresh the catalog, the related client(such as HMSClient) should be closed, or the connection may be leaked. 2. Remove some unused code related to deprecated hive external table
Proposed changes
When refresh the catalog, the related client(such as HMSClient) should be closed,
or the connection may be leaked.
Remove some unused code related to deprecated hive external table
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...