Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](restore) Fix restore table name when lower_case_table_names enabled #35508

Merged
merged 1 commit into from
May 28, 2024
Merged

[fix](restore) Fix restore table name when lower_case_table_names enabled #35508

merged 1 commit into from
May 28, 2024
+5 −1

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented May 28, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.
dataroaring
dataroaring approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.
@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 28, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.
@dataroaring
Copy link
Contributor

run buildall
@doris-robot
Copy link

TPC-H: Total hot run time: 41396 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c33726f95da116995e3de56567456704544ded29, data reload: false

------ Round 1 ----------------------------------
q1	17660	4344	4310	4310
q2	2026	197	199	197
q3	10506	1243	1200	1200
q4	10214	829	840	829
q5	7477	2705	2713	2705
q6	230	132	141	132
q7	966	615	615	615
q8	9247	2145	2095	2095
q9	10164	6736	6724	6724
q10	9223	3847	3876	3847
q11	448	244	260	244
q12	437	230	226	226
q13	18282	3196	3250	3196
q14	258	217	234	217
q15	501	471	467	467
q16	513	405	395	395
q17	997	700	696	696
q18	8445	7794	8022	7794
q19	4561	1591	1582	1582
q20	669	312	325	312
q21	5296	3375	3333	3333
q22	351	280	281	280
Total cold run time: 118471 ms
Total hot run time: 41396 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4514	4390	4445	4390
q2	369	266	274	266
q3	3158	2941	2910	2910
q4	2012	1655	1605	1605
q5	5370	5518	5467	5467
q6	217	124	132	124
q7	2246	1797	1806	1797
q8	3250	3427	3404	3404
q9	8609	8706	8728	8706
q10	4105	3741	3723	3723
q11	606	498	486	486
q12	787	610	631	610
q13	15969	3174	3175	3174
q14	299	262	291	262
q15	509	507	475	475
q16	472	436	448	436
q17	1799	1520	1494	1494
q18	7911	7572	7391	7391
q19	1665	1572	1566	1566
q20	1968	1802	1814	1802
q21	10615	4758	4686	4686
q22	555	500	494	494
Total cold run time: 77005 ms
Total hot run time: 55268 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 168892 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c33726f95da116995e3de56567456704544ded29, data reload: false

query1	920	377	376	376
query2	6440	2487	2290	2290
query3	6642	202	210	202
query4	20458	17168	17540	17168
query5	4185	416	414	414
query6	241	160	149	149
query7	4583	307	290	290
query8	242	186	181	181
query9	8883	2440	2402	2402
query10	433	272	251	251
query11	10383	10144	10033	10033
query12	129	89	86	86
query13	1641	378	358	358
query14	9436	6830	7602	6830
query15	206	163	167	163
query16	7709	270	257	257
query17	1722	545	504	504
query18	1950	267	297	267
query19	200	151	159	151
query20	89	87	86	86
query21	203	132	131	131
query22	4261	4044	3895	3895
query23	34891	33172	32902	32902
query24	11789	2860	2745	2745
query25	540	354	383	354
query26	1101	162	156	156
query27	2810	314	323	314
query28	7090	2077	2094	2077
query29	834	623	606	606
query30	266	145	152	145
query31	975	749	765	749
query32	91	54	56	54
query33	750	288	261	261
query34	950	469	472	469
query35	772	609	603	603
query36	1043	913	887	887
query37	186	66	69	66
query38	2904	2777	2763	2763
query39	854	785	808	785
query40	244	127	123	123
query41	46	44	43	43
query42	104	94	97	94
query43	564	530	520	520
query44	1180	726	741	726
query45	180	158	158	158
query46	1068	713	738	713
query47	1864	1733	1748	1733
query48	389	302	300	300
query49	950	410	441	410
query50	768	390	394	390
query51	6773	6851	6778	6778
query52	100	90	91	90
query53	352	285	279	279
query54	843	442	420	420
query55	69	73	73	73
query56	250	242	247	242
query57	1112	1008	1044	1008
query58	226	213	212	212
query59	3390	3155	3190	3155
query60	279	250	265	250
query61	89	107	137	107
query62	609	461	460	460
query63	307	287	282	282
query64	9549	2202	1745	1745
query65	3337	3119	3118	3118
query66	1186	332	343	332
query67	15369	14755	15144	14755
query68	4593	555	560	555
query69	457	282	276	276
query70	1089	1078	1140	1078
query71	418	272	282	272
query72	7581	2858	2702	2702
query73	723	329	332	329
query74	5969	5562	5594	5562
query75	3351	2663	2594	2594
query76	2649	959	1023	959
query77	388	269	267	267
query78	10361	9928	9611	9611
query79	2049	511	508	508
query80	1197	451	448	448
query81	530	222	220	220
query82	742	94	101	94
query83	253	180	175	175
query84	255	90	90	90
query85	2167	333	315	315
query86	482	285	299	285
query87	3288	3101	3094	3094
query88	3948	2426	2434	2426
query89	478	387	385	385
query90	2025	189	187	187
query91	136	110	107	107
query92	60	51	51	51
query93	2380	524	508	508
query94	1339	193	195	193
query95	414	316	315	315
query96	597	272	274	272
query97	3207	2993	3026	2993
query98	238	218	211	211
query99	1143	874	884	874
Total cold run time: 274506 ms
Total hot run time: 168892 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 30.67 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c33726f95da116995e3de56567456704544ded29, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.68	0.06	0.07
query5	0.49	0.50	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.02
query8	0.04	0.04	0.05
query9	0.53	0.50	0.48
query10	0.55	0.56	0.54
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.58	0.60	0.61
query14	0.78	0.78	0.77
query15	0.82	0.80	0.80
query16	0.37	0.37	0.36
query17	0.99	0.99	0.95
query18	0.21	0.24	0.23
query19	1.82	1.73	1.66
query20	0.01	0.01	0.01
query21	15.70	0.67	0.65
query22	4.62	7.31	1.96
query23	18.30	1.35	1.31
query24	1.37	0.37	0.27
query25	0.15	0.08	0.08
query26	0.25	0.17	0.16
query27	0.08	0.08	0.08
query28	13.27	1.01	1.00
query29	13.57	3.31	3.32
query30	0.24	0.06	0.05
query31	2.90	0.38	0.38
query32	3.30	0.47	0.47
query33	2.88	2.92	2.88
query34	17.31	4.42	4.43
query35	4.57	4.55	4.60
query36	0.68	0.47	0.45
query37	0.18	0.15	0.15
query38	0.16	0.15	0.14
query39	0.04	0.04	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.04
query42	0.06	0.04	0.04
query43	0.04	0.03	0.04
Total cold run time: 110.58 s
Total hot run time: 30.67 s
@dataroaring dataroaring merged commit 118ca08 into apache:master May 28, 2024
30 of 33 checks passed
@w41ter w41ter deleted the fix/doris_restore_with_lower_case_table_names branch May 28, 2024 14:35
w41ter added a commit to w41ter/incubator-doris that referenced this pull request May 29, 2024
@w41ter
[fix](restore) Fix restore table name when lower_case_table_names ena…
7cae02e 
…bled

Cherry-pick apache#35508
@w41ter w41ter mentioned this pull request May 29, 2024
Merged
dataroaring pushed a commit that referenced this pull request May 29, 2024
@w41ter
[fix](restore) Fix restore table name when lower_case_table_names ena…
ec85b1c 
…bled (#35566)

Cherry-pick #35508
yiguolei pushed a commit that referenced this pull request May 29, 2024
@w41ter @Doris-Extras
[fix](restore) Fix restore table name when lower_case_table_names ena…
646d8ea 
…bled (#35508)
dataroaring pushed a commit that referenced this pull request May 31, 2024
@w41ter @dataroaring
[fix](restore) Fix restore table name when lower_case_table_names ena…
277f3dc 
…bled (#35508)
@yiguolei yiguolei mentioned this pull request Jun 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
6 participants
@w41ter @doris-robot @dataroaring @liaoxin01 @platoneko @ByteYue