[Fix](tvf) Pass through user-defined properties #35515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 40045 ms |
TPC-DS: Total hot run time: 173721 ms |
ClickBench: Total hot run time: 31.14 s |
|
run buildall |
TPC-H: Total hot run time: 41699 ms |
TPC-DS: Total hot run time: 167914 ms |
ClickBench: Total hot run time: 30.65 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
morningman
force-pushed
the
fixTvfProperties
branch
from
1a173ec
to
ecc779f
Compare
|
run buildall |
TPC-H: Total hot run time: 39706 ms |
TPC-H: Total hot run time: 40133 ms |
TPC-DS: Total hot run time: 172701 ms |
ClickBench: Total hot run time: 29.85 s |
morningman
approved these changes
May 31, 2024
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
May 31, 2024
## Proposed changes Issue Number: close #xxx Previously, irrelevant properties passed by users when using TVF were directly ignored by Doris. Now, we retain and pass these additional user-defined properties to the S3 SDK. <!--Describe your changes.--> ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
morningman
added a commit
that referenced
this pull request
May 31, 2024
Closed
morningman
added a commit
that referenced
this pull request
Jun 3, 2024
## Proposed changes Introduced from #35515 1. Fix invalid `to_int()` method logic 2. Remove unnecessary properties when creating s3 resource Before, after recreating s3 resource, there will be some extra properties being added to the resource properties, such as AWS_ACCESS_KEY, but this keys are only for s3 client on BE side, don' t needed when ping s3. But it will add some invalid properties such as `AWS_TOKEN=null`
dataroaring
pushed a commit
that referenced
this pull request
Jun 4, 2024
## Proposed changes Issue Number: close #xxx Previously, irrelevant properties passed by users when using TVF were directly ignored by Doris. Now, we retain and pass these additional user-defined properties to the S3 SDK. <!--Describe your changes.--> ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
dataroaring
pushed a commit
that referenced
this pull request
Jun 4, 2024
## Proposed changes Introduced from #35515 1. Fix invalid `to_int()` method logic 2. Remove unnecessary properties when creating s3 resource Before, after recreating s3 resource, there will be some extra properties being added to the resource properties, such as AWS_ACCESS_KEY, but this keys are only for s3 client on BE side, don' t needed when ping s3. But it will add some invalid properties such as `AWS_TOKEN=null`
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
## Proposed changes Issue Number: close #xxx Previously, irrelevant properties passed by users when using TVF were directly ignored by Doris. Now, we retain and pass these additional user-defined properties to the S3 SDK. <!--Describe your changes.--> ## Further comments If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
## Proposed changes Introduced from apache#35515 1. Fix invalid `to_int()` method logic 2. Remove unnecessary properties when creating s3 resource Before, after recreating s3 resource, there will be some extra properties being added to the resource properties, such as AWS_ACCESS_KEY, but this keys are only for s3 client on BE side, don' t needed when ping s3. But it will add some invalid properties such as `AWS_TOKEN=null`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
Previously, irrelevant properties passed by users when using TVF were directly ignored by Doris.
Now, we retain and pass these additional user-defined properties to the S3 SDK.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...