[fix](orc)fix orc reader missing column and filter missing column. #35583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
hubgeter
force-pushed
the
fix_orc_missing_col
branch
from
8f7f77c
to
08c701f
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 42277 ms |
TPC-DS: Total hot run time: 172169 ms |
ClickBench: Total hot run time: 30.35 s |
|
TeamCity be ut coverage result: |
hubgeter
force-pushed
the
fix_orc_missing_col
branch
from
08c701f
to
d554f48
Compare
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41157 ms |
AshinGau
previously approved these changes
May 31, 2024
|
LGTM |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 43915 ms |
TPC-DS: Total hot run time: 169637 ms |
ClickBench: Total hot run time: 30.61 s |
This was referenced May 31, 2024
|
run buildall |
github-actions
bot
removed
the
approved
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 39993 ms |
|
TeamCity be ut coverage result: |
TPC-DS: Total hot run time: 168760 ms |
ClickBench: Total hot run time: 30.79 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
yiguolei
pushed a commit
that referenced
this pull request
May 31, 2024
## Proposed changes bp #35583 Issue Number: close #xxx <!--Describe your changes.-->
morningman
pushed a commit
that referenced
this pull request
May 31, 2024
morningman
approved these changes
May 31, 2024
AshinGau
approved these changes
May 31, 2024
Closed
dataroaring
pushed a commit
that referenced
this pull request
Jun 4, 2024
…35583) Fixed the problem that filtering with non-existent columns failed when reading orc tables example : ``` mysql> select * from sc_test; +------+------+-------+----------------------+----------+ | id | type | state | sensitive_query_flag | dt | +------+------+-------+----------------------+----------+ | 5 | 6 | bac | NULL | 20240226 | | 3 | 4 | bac | NULL | 20240227 | | 1 | 2 | bac | 1 | 20240228 | +------+------+-------+----------------------+----------+ 3 rows in set (0.03 sec) mysql> select * from sc_test where sensitive_query_flag is null; 0 rows in set (0.03 sec) ``` after : ``` mysql> select * from sc_test where sensitive_query_flag is null; +------+------+-------+----------------------+----------+ | id | type | state | sensitive_query_flag | dt | +------+------+-------+----------------------+----------+ | 3 | 4 | bac | NULL | 20240227 | | 5 | 6 | bac | NULL | 20240226 | +------+------+-------+----------------------+----------+ 2 rows in set (0.03 sec) ```
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
…pache#35583) Fixed the problem that filtering with non-existent columns failed when reading orc tables example : ``` mysql> select * from sc_test; +------+------+-------+----------------------+----------+ | id | type | state | sensitive_query_flag | dt | +------+------+-------+----------------------+----------+ | 5 | 6 | bac | NULL | 20240226 | | 3 | 4 | bac | NULL | 20240227 | | 1 | 2 | bac | 1 | 20240228 | +------+------+-------+----------------------+----------+ 3 rows in set (0.03 sec) mysql> select * from sc_test where sensitive_query_flag is null; 0 rows in set (0.03 sec) ``` after : ``` mysql> select * from sc_test where sensitive_query_flag is null; +------+------+-------+----------------------+----------+ | id | type | state | sensitive_query_flag | dt | +------+------+-------+----------------------+----------+ | 3 | 4 | bac | NULL | 20240227 | | 5 | 6 | bac | NULL | 20240226 | +------+------+-------+----------------------+----------+ 2 rows in set (0.03 sec) ```
This was referenced Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixed the problem that filtering with non-existent columns failed when reading orc tables
example :
after :
Issue Number: close #xxx