Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](resource-tag) missing resource tag after forwarding to master #35618

Merged
merged 1 commit into from
May 30, 2024
Merged

[fix](resource-tag) missing resource tag after forwarding to master #35618

merged 1 commit into from
May 30, 2024

Conversation

morningman
Copy link
Contributor

Proposed changes

All DDL and DML will be forwarded to Master FE.
And we forgot to set resource tag in ConnectionContext
after forwarding
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.
@morningman
Copy link
Contributor Author

run buildall
@morningman morningman added usercase Important user case type label dev/1.2.9 and removed doc-1.2.x labels May 29, 2024
@doris-robot
Copy link

TPC-H: Total hot run time: 40242 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c343c83819935fd12483b43094bf9ba99c42a118, data reload: false

------ Round 1 ----------------------------------
q1	18036	4918	4347	4347
q2	2694	208	215	208
q3	11958	1164	1218	1164
q4	10713	910	783	783
q5	7833	2714	2682	2682
q6	225	134	137	134
q7	967	587	591	587
q8	9224	2066	2077	2066
q9	9129	6495	6489	6489
q10	8935	3696	3697	3696
q11	450	250	234	234
q12	425	230	223	223
q13	18587	2996	2976	2976
q14	271	224	236	224
q15	513	470	476	470
q16	525	382	378	378
q17	962	711	813	711
q18	7995	7497	7318	7318
q19	4870	1641	1590	1590
q20	665	310	307	307
q21	4926	3328	3914	3328
q22	380	330	327	327
Total cold run time: 120283 ms
Total hot run time: 40242 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4333	4199	4230	4199
q2	395	264	265	264
q3	2976	2721	2781	2721
q4	1874	1619	1599	1599
q5	5251	5284	5267	5267
q6	209	122	127	122
q7	2072	1787	1764	1764
q8	3175	3304	3324	3304
q9	8336	8375	8422	8375
q10	3894	3692	3685	3685
q11	607	496	493	493
q12	763	584	600	584
q13	16394	2997	3002	2997
q14	303	250	253	250
q15	511	458	483	458
q16	470	409	419	409
q17	1773	1470	1472	1470
q18	7599	7447	7379	7379
q19	1701	1528	1634	1528
q20	1984	1792	1801	1792
q21	4900	4660	4573	4573
q22	617	536	534	534
Total cold run time: 70137 ms
Total hot run time: 53767 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 169975 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c343c83819935fd12483b43094bf9ba99c42a118, data reload: false

query1	934	374	370	370
query2	6452	2471	2406	2406
query3	6656	217	217	217
query4	21532	17364	17415	17364
query5	4144	435	417	417
query6	262	174	169	169
query7	4600	306	292	292
query8	358	293	280	280
query9	8532	2398	2394	2394
query10	445	277	256	256
query11	10582	10274	10077	10077
query12	145	89	86	86
query13	1653	361	355	355
query14	10206	7092	7490	7092
query15	234	188	190	188
query16	8023	288	258	258
query17	1816	531	512	512
query18	2069	276	276	276
query19	209	155	148	148
query20	91	89	86	86
query21	196	136	130	130
query22	4273	3964	3881	3881
query23	33953	33019	33186	33019
query24	11180	2808	2900	2808
query25	601	355	357	355
query26	1349	152	153	152
query27	2945	320	321	320
query28	7629	2049	2074	2049
query29	871	616	629	616
query30	276	146	155	146
query31	965	773	728	728
query32	90	52	53	52
query33	754	267	264	264
query34	1021	478	483	478
query35	726	608	589	589
query36	1064	963	911	911
query37	135	68	68	68
query38	2912	2857	2768	2768
query39	820	804	786	786
query40	203	126	124	124
query41	54	51	52	51
query42	100	97	96	96
query43	587	559	539	539
query44	1242	728	765	728
query45	185	174	170	170
query46	1079	697	692	692
query47	1859	1759	1799	1759
query48	368	291	296	291
query49	1069	382	388	382
query50	768	414	397	397
query51	6909	6879	6712	6712
query52	101	93	93	93
query53	353	293	286	286
query54	871	420	420	420
query55	75	73	74	73
query56	256	236	241	236
query57	1078	1028	1059	1028
query58	238	210	210	210
query59	3596	3493	3271	3271
query60	268	255	260	255
query61	90	86	91	86
query62	646	470	450	450
query63	323	295	288	288
query64	8907	2261	1732	1732
query65	3179	3175	3157	3157
query66	1397	332	333	332
query67	15271	14822	14861	14822
query68	4605	539	532	532
query69	441	264	278	264
query70	1121	1153	1108	1108
query71	409	273	267	267
query72	7559	2728	2544	2544
query73	720	318	320	318
query74	6131	5640	5639	5639
query75	3384	2634	2649	2634
query76	2433	948	1073	948
query77	466	263	263	263
query78	10371	9822	9923	9822
query79	2579	509	516	509
query80	1065	435	425	425
query81	519	228	219	219
query82	737	90	94	90
query83	240	171	173	171
query84	238	94	83	83
query85	1356	262	261	261
query86	505	327	290	290
query87	3304	3090	3147	3090
query88	4278	2350	2355	2350
query89	487	402	385	385
query90	1943	198	198	198
query91	135	107	112	107
query92	65	51	54	51
query93	1768	512	493	493
query94	1164	200	198	198
query95	419	318	321	318
query96	592	273	269	269
query97	3186	3006	3067	3006
query98	243	224	221	221
query99	1133	859	869	859
Total cold run time: 275371 ms
Total hot run time: 169975 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 30.34 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c343c83819935fd12483b43094bf9ba99c42a118, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.67	0.07	0.07
query5	0.49	0.47	0.54
query6	1.12	0.72	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.53	0.50	0.49
query10	0.55	0.55	0.53
query11	0.15	0.11	0.12
query12	0.14	0.12	0.11
query13	0.60	0.60	0.59
query14	0.78	0.78	0.77
query15	0.83	0.81	0.82
query16	0.36	0.36	0.36
query17	1.04	0.96	1.03
query18	0.22	0.25	0.26
query19	1.77	1.69	1.71
query20	0.01	0.01	0.01
query21	15.49	0.70	0.67
query22	4.28	7.31	1.80
query23	18.32	1.45	1.26
query24	1.86	0.27	0.27
query25	0.14	0.09	0.08
query26	0.26	0.17	0.16
query27	0.07	0.08	0.08
query28	13.29	1.01	1.00
query29	13.15	3.27	3.32
query30	0.24	0.06	0.05
query31	2.86	0.39	0.38
query32	3.27	0.48	0.46
query33	2.89	2.91	2.86
query34	16.93	4.41	4.39
query35	4.55	4.51	4.46
query36	0.64	0.46	0.48
query37	0.18	0.15	0.16
query38	0.15	0.14	0.15
query39	0.05	0.03	0.03
query40	0.17	0.13	0.15
query41	0.09	0.04	0.04
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.66 s
Total hot run time: 30.34 s
wangbo
wangbo approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.
@yiguolei yiguolei merged commit 3c11f09 into apache:master May 30, 2024
27 of 29 checks passed
yiguolei pushed a commit that referenced this pull request May 30, 2024
@morningman @Doris-Extras
[fix](resource-tag) missing resource tag after forwarding to master (#…
0ed7dc1 
…35618)

## Proposed changes

All DDL and DML will be forwarded to Master FE.
And we forgot to set resource tag in ConnectionContext
after forwarding
morningman added a commit to morningman/doris that referenced this pull request May 30, 2024
@morningman
[fix](resource-tag) missing resource tag after forwarding to master (a…
2511e45 
…pache#35618)

All DDL and DML will be forwarded to Master FE.
And we forgot to set resource tag in ConnectionContext
after forwarding
@morningman morningman mentioned this pull request May 30, 2024
Merged
xiaokang pushed a commit that referenced this pull request May 30, 2024
@morningman
[fix](resource-tag) missing resource tag after forwarding to master #…
158ff88 
…35618 (#35677)
dataroaring pushed a commit that referenced this pull request May 31, 2024
@morningman @dataroaring
[fix](resource-tag) missing resource tag after forwarding to master (#…
b9d9d2e 
…35618)

## Proposed changes

All DDL and DML will be forwarded to Master FE.
And we forgot to set resource tag in ConnectionContext
after forwarding
@yiguolei yiguolei mentioned this pull request Jun 1, 2024
Closed
morningman added a commit to morningman/doris that referenced this pull request Jun 17, 2024
@morningman
[fix](resource-tag) missing resource tag after forwarding to master (a…
7e60b24 
…pache#35618)

## Proposed changes

All DDL and DML will be forwarded to Master FE.
And we forgot to set resource tag in ConnectionContext
after forwarding
@morningman morningman mentioned this pull request Jun 17, 2024
Merged
morningman added a commit that referenced this pull request Jun 17, 2024
@morningman
[fix](resource-tag) missing resource tag after forwarding to master (#…
71596e9 
…35618) (#36370)

bp #35618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/1.2.9-merged dev/2.0.11-merged dev/2.1.4-merged dev/3.0.0-merged reviewed usercase Important user case type label
6 participants
@morningman @doris-robot @yiguolei @wangbo @xiaokang @gavinchou