Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](nereids) do not generate runtime filter on schema-scan #35655

Merged
merged 1 commit into from
May 30, 2024
Merged

[fix](nereids) do not generate runtime filter on schema-scan #35655

merged 1 commit into from
May 30, 2024

Conversation

englefly
Copy link
Contributor

@englefly englefly commented May 30, 2024 •
edited
Loading

Proposed changes

schema-scan node does not support runtime filter

Issue Number: close #xxx
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.
@englefly
Copy link
Contributor Author

run buildall
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.
@englefly englefly mentioned this pull request May 30, 2024
Merged
@doris-robot
Copy link

TPC-H: Total hot run time: 41167 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 99c107852cc08f6c25445e42c98bf04e67ab5493, data reload: false

------ Round 1 ----------------------------------
q1	17602	4374	4272	4272
q2	2016	198	194	194
q3	10431	1300	1160	1160
q4	10202	791	773	773
q5	7510	2713	2754	2713
q6	217	130	135	130
q7	970	618	605	605
q8	9221	2144	2101	2101
q9	9304	6712	6691	6691
q10	9248	3944	3892	3892
q11	469	241	242	241
q12	478	220	223	220
q13	17234	3185	3223	3185
q14	267	229	216	216
q15	517	471	477	471
q16	498	384	373	373
q17	970	722	733	722
q18	8369	7836	7712	7712
q19	6315	1628	1627	1627
q20	641	311	307	307
q21	5181	4232	3238	3238
q22	417	338	324	324
Total cold run time: 118077 ms
Total hot run time: 41167 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4510	4532	4430	4430
q2	389	271	265	265
q3	3125	2874	2953	2874
q4	1974	1665	1608	1608
q5	5286	5495	5478	5478
q6	219	120	122	120
q7	2193	1842	1748	1748
q8	3250	3407	3398	3398
q9	8580	8628	8659	8628
q10	4133	3821	3689	3689
q11	597	500	509	500
q12	790	629	635	629
q13	17066	3123	3157	3123
q14	291	259	278	259
q15	529	488	465	465
q16	512	442	460	442
q17	1798	1531	1491	1491
q18	7877	7707	7509	7509
q19	1661	1550	1581	1550
q20	2038	1785	1811	1785
q21	12497	4748	4798	4748
q22	594	523	526	523
Total cold run time: 79909 ms
Total hot run time: 55262 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 169637 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 99c107852cc08f6c25445e42c98bf04e67ab5493, data reload: false

query1	932	398	371	371
query2	6453	2488	2217	2217
query3	6638	213	214	213
query4	19111	17430	17171	17171
query5	4126	421	418	418
query6	241	152	153	152
query7	4579	306	285	285
query8	336	292	281	281
query9	8680	2400	2377	2377
query10	442	281	255	255
query11	10580	10045	10073	10045
query12	135	96	90	90
query13	1632	363	367	363
query14	10005	7677	8019	7677
query15	243	191	194	191
query16	7162	283	267	267
query17	1338	521	516	516
query18	1851	274	274	274
query19	201	151	148	148
query20	92	84	87	84
query21	209	130	129	129
query22	4156	3946	3920	3920
query23	33472	32904	32977	32904
query24	5134	2784	2847	2784
query25	467	360	363	360
query26	694	160	160	160
query27	1834	312	333	312
query28	3703	2088	2080	2080
query29	869	620	600	600
query30	230	153	155	153
query31	917	753	752	752
query32	61	52	55	52
query33	439	278	265	265
query34	869	457	462	457
query35	703	618	609	609
query36	1050	921	936	921
query37	104	66	69	66
query38	2866	2784	2737	2737
query39	868	787	792	787
query40	200	127	124	124
query41	85	55	52	52
query42	105	97	99	97
query43	599	542	538	538
query44	1060	748	744	744
query45	184	167	172	167
query46	1040	708	716	708
query47	1843	1757	1786	1757
query48	361	301	287	287
query49	757	394	377	377
query50	763	392	392	392
query51	6891	6689	6684	6684
query52	110	88	90	88
query53	355	286	284	284
query54	522	433	435	433
query55	75	71	72	71
query56	263	238	245	238
query57	1153	1036	1051	1036
query58	225	205	242	205
query59	3515	3282	3135	3135
query60	275	272	271	271
query61	90	84	84	84
query62	538	439	449	439
query63	325	289	288	288
query64	2584	1760	1790	1760
query65	3192	3101	3123	3101
query66	592	322	321	321
query67	15248	14619	14688	14619
query68	4453	545	527	527
query69	414	269	262	262
query70	1148	1110	1138	1110
query71	374	275	262	262
query72	7699	5203	2724	2724
query73	704	320	316	316
query74	5894	5579	5585	5579
query75	3335	2604	2615	2604
query76	2310	1042	929	929
query77	396	265	274	265
query78	10232	9764	9752	9752
query79	2173	517	525	517
query80	884	453	454	453
query81	514	222	218	218
query82	1130	98	93	93
query83	246	179	177	177
query84	255	88	90	88
query85	1196	299	263	263
query86	463	279	301	279
query87	3306	3126	3147	3126
query88	4157	2361	2353	2353
query89	470	383	384	383
query90	2045	192	185	185
query91	124	97	96	96
query92	59	48	50	48
query93	2174	513	494	494
query94	1206	183	183	183
query95	393	317	309	309
query96	587	263	261	261
query97	3191	2986	3006	2986
query98	243	219	209	209
query99	1229	901	843	843
Total cold run time: 249376 ms
Total hot run time: 169637 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 30.69 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 99c107852cc08f6c25445e42c98bf04e67ab5493, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.06
query4	1.68	0.09	0.10
query5	0.50	0.49	0.55
query6	1.16	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.54	0.49	0.49
query10	0.54	0.54	0.54
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.59	0.58	0.60
query14	0.78	0.79	0.80
query15	0.83	0.82	0.81
query16	0.35	0.36	0.37
query17	0.95	0.97	0.96
query18	0.20	0.27	0.23
query19	1.85	1.71	1.71
query20	0.02	0.01	0.01
query21	15.47	0.69	0.68
query22	4.45	7.00	2.05
query23	18.32	1.44	1.21
query24	1.63	0.34	0.22
query25	0.15	0.09	0.09
query26	0.27	0.17	0.16
query27	0.08	0.08	0.07
query28	13.25	1.03	1.00
query29	13.07	3.33	3.27
query30	0.25	0.05	0.05
query31	2.90	0.38	0.38
query32	3.31	0.48	0.46
query33	2.85	2.92	2.91
query34	17.12	4.43	4.43
query35	4.48	4.46	4.65
query36	0.68	0.49	0.46
query37	0.18	0.16	0.16
query38	0.15	0.15	0.14
query39	0.05	0.04	0.03
query40	0.16	0.14	0.15
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.03	0.03
Total cold run time: 109.72 s
Total hot run time: 30.69 s
@yiguolei yiguolei merged commit d2a2e22 into apache:master May 30, 2024
27 of 30 checks passed
yiguolei pushed a commit that referenced this pull request May 30, 2024
@englefly @Doris-Extras
[fix](nereids) do not generate runtime filter on schema-scan (#35655)
64023c5 
## Proposed changes
schema-scan node does not support runtime filter

Issue Number: close #xxx

<!--Describe your changes.-->
xiaokang pushed a commit that referenced this pull request May 30, 2024
@englefly
[fix](nereids)schema-scan node does not support runtime filter #35655 (…
7d9c4a2 
…#35658)
dataroaring pushed a commit that referenced this pull request May 31, 2024
@englefly @dataroaring
[fix](nereids) do not generate runtime filter on schema-scan (#35655)
742e264 
## Proposed changes
schema-scan node does not support runtime filter

Issue Number: close #xxx

<!--Describe your changes.-->
@morningman morningman mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.11-merged dev/2.1.4-merged reviewed
4 participants
@englefly @doris-robot @yiguolei @morrySnow