[Fix](Variant) fix variant with empty key #35671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some senario empty key will cause crash like ``` *** tablet *** SIGSEGV unknown detail explain (@0x0) received by PID 1527747 ( TID 1544788 OR 0x7f3302988700) from PID 0; stack trace: *** 0# doris::signal::(anonymous namespace)::FailureSignalHandler(int, siginfo_t* , void*) at /mnt/disk2/lihangyu/doris/be/src/common/signal_handler.h:429 1# 0x00007F4880A12B50 in /lib64/libc.so.6 2# doris::vectorized::PathInDataBuilder::append(std::basic_string_view<char, std::char_traits<char> >, bool) at /mnt/disk2/lihangyu/doris/be/src/vec/json/p ath_in_data.cpp:193 3# doris::vectorized::JSONDataParser<doris::vectorized::SimdJSONParser, false >::traverseObject(doris::vectorized::SimdJSONParser::Object const&, doris::vec torized::JSONDataParser<doris::vectorized::SimdJSONParser, false>::ParseContex t&) at /mnt/disk2/lihangyu/doris/be/src/vec/json/json_parser.cpp:121 4# doris::vectorized::JSONDataParser<doris::vectorized::SimdJSONParser, false >::traverse(doris::vectorized::SimdJSONParser::Element const&, doris::vectoriz ed::JSONDataParser<doris::vectorized::SimdJSONParser, false>::ParseContext&) a t /mnt/disk2/lihangyu/doris/be/src/vec/json/json_parser.cpp:95 5# doris::vectorized::JSONDataParser<doris::vectorized::SimdJSONParser, false >::parse(char const*, unsigned long) at /mnt/disk2/lihangyu/doris/be/src/vec/j son/json_parser.cpp:81 ```
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
clang-tidy review says "All clean, LGTM! 👍" |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some senario empty key will cause crash like
Proposed changes
Issue Number: close #xxx