Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve](session) print more error msg when set a wrong session variable name #35775

Merged
merged 1 commit into from
Jun 3, 2024
Merged

[improve](session) print more error msg when set a wrong session variable name #35775

merged 1 commit into from
Jun 3, 2024

Conversation

zhangstar333
Copy link
Contributor

Proposed changes

when set a wrong session variable, eg:
mysql [(none)]>set enable_profileXXXXXXX=true;
ERROR 1228 (HY000): errCode = 2, detailMessage = Unknown system variable 'enable_profileXXXXXXX', the similar variables are {'enable_profile', 'enable_force_spill', 'enable_projection'}
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.
@zhangstar333
Copy link
Contributor Author

run buildall
@doris-robot
Copy link

TPC-H: Total hot run time: 40124 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5dd0ec406f85f0a1b08c75b2f2e84d73de44957c, data reload: false

------ Round 1 ----------------------------------
q1	17963	4572	4471	4471
q2	2573	193	200	193
q3	11053	1221	1185	1185
q4	10210	824	824	824
q5	7933	2716	2788	2716
q6	222	136	141	136
q7	973	629	616	616
q8	9654	2074	2091	2074
q9	8966	6449	6436	6436
q10	8893	3745	3698	3698
q11	457	259	244	244
q12	429	237	237	237
q13	17780	2990	3009	2990
q14	272	222	217	217
q15	517	475	466	466
q16	516	388	382	382
q17	961	664	758	664
q18	8048	7298	7280	7280
q19	6324	1499	1547	1499
q20	654	319	304	304
q21	4921	3152	3225	3152
q22	390	340	345	340
Total cold run time: 119709 ms
Total hot run time: 40124 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4375	4266	4212	4212
q2	378	276	279	276
q3	2980	2840	2757	2757
q4	1846	1682	1611	1611
q5	5233	5271	5233	5233
q6	218	131	133	131
q7	2147	1744	1714	1714
q8	3174	3344	3275	3275
q9	8339	8306	8307	8306
q10	3866	3678	3679	3678
q11	573	480	499	480
q12	771	617	603	603
q13	16338	2992	2973	2973
q14	303	268	260	260
q15	522	479	478	478
q16	484	433	406	406
q17	1770	1468	1468	1468
q18	7557	7536	7398	7398
q19	4035	1634	1591	1591
q20	1982	1784	1803	1784
q21	4949	4699	4780	4699
q22	638	553	531	531
Total cold run time: 72478 ms
Total hot run time: 53864 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 172120 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5dd0ec406f85f0a1b08c75b2f2e84d73de44957c, data reload: false

query1	936	381	376	376
query2	6448	2484	2212	2212
query3	6654	206	207	206
query4	20086	17339	17275	17275
query5	4157	478	447	447
query6	256	164	156	156
query7	4580	303	306	303
query8	321	298	276	276
query9	8572	2381	2358	2358
query10	452	309	282	282
query11	10452	9977	10056	9977
query12	145	91	89	89
query13	1641	386	383	383
query14	10173	7899	6909	6909
query15	237	198	192	192
query16	7803	263	266	263
query17	1836	530	536	530
query18	1911	271	276	271
query19	205	157	157	157
query20	97	85	82	82
query21	240	147	129	129
query22	4198	4189	3988	3988
query23	33821	32889	32943	32889
query24	11980	2796	2811	2796
query25	668	377	363	363
query26	1777	160	155	155
query27	2906	330	326	326
query28	6889	2045	2071	2045
query29	1119	634	611	611
query30	291	147	157	147
query31	975	764	745	745
query32	90	53	57	53
query33	777	281	277	277
query34	970	491	508	491
query35	764	596	613	596
query36	1101	925	927	925
query37	208	71	79	71
query38	2854	2734	2735	2734
query39	883	805	813	805
query40	276	130	128	128
query41	56	56	53	53
query42	125	103	97	97
query43	608	551	540	540
query44	1206	752	761	752
query45	204	174	166	166
query46	1080	713	718	713
query47	1843	1735	1763	1735
query48	379	313	313	313
query49	1188	418	410	410
query50	785	391	387	387
query51	6867	6802	6692	6692
query52	105	97	89	89
query53	367	299	294	294
query54	1015	455	457	455
query55	75	75	75	75
query56	270	257	266	257
query57	1118	1062	1012	1012
query58	270	250	282	250
query59	3477	3168	3098	3098
query60	282	276	289	276
query61	89	87	91	87
query62	649	441	439	439
query63	329	293	290	290
query64	9863	2203	1783	1783
query65	3192	3129	3119	3119
query66	1366	329	328	328
query67	15248	14767	14929	14767
query68	4643	583	582	582
query69	453	315	308	308
query70	1130	1154	1156	1154
query71	370	293	293	293
query72	6991	5197	5323	5197
query73	756	344	334	334
query74	5933	5518	5435	5435
query75	3350	2668	2615	2615
query76	2466	913	923	913
query77	464	301	288	288
query78	10204	9735	9773	9735
query79	2770	526	527	526
query80	1186	543	461	461
query81	575	223	218	218
query82	798	101	102	101
query83	239	170	175	170
query84	244	92	86	86
query85	1434	283	285	283
query86	476	300	299	299
query87	3244	3071	3091	3071
query88	3957	2435	2442	2435
query89	465	403	390	390
query90	1787	196	192	192
query91	129	101	99	99
query92	67	51	53	51
query93	1891	547	527	527
query94	1260	201	193	193
query95	398	368	316	316
query96	599	294	271	271
query97	3143	3047	3043	3043
query98	241	218	216	216
query99	1181	825	823	823
Total cold run time: 274649 ms
Total hot run time: 172120 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 30.73 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5dd0ec406f85f0a1b08c75b2f2e84d73de44957c, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.47	0.48
query6	1.13	0.72	0.71
query7	0.02	0.01	0.01
query8	0.05	0.03	0.04
query9	0.54	0.49	0.49
query10	0.54	0.55	0.54
query11	0.15	0.11	0.12
query12	0.15	0.12	0.11
query13	0.60	0.59	0.59
query14	0.80	0.77	0.79
query15	0.83	0.80	0.82
query16	0.37	0.37	0.35
query17	0.96	1.03	1.00
query18	0.22	0.22	0.24
query19	1.89	1.66	1.67
query20	0.01	0.01	0.01
query21	15.47	0.68	0.66
query22	4.39	6.68	2.15
query23	18.27	1.47	1.31
query24	1.96	0.22	0.22
query25	0.15	0.09	0.09
query26	0.27	0.17	0.17
query27	0.08	0.08	0.07
query28	13.29	1.02	1.01
query29	12.81	3.29	3.29
query30	0.24	0.05	0.06
query31	2.88	0.39	0.38
query32	3.27	0.47	0.48
query33	2.90	2.85	2.93
query34	17.14	4.41	4.38
query35	4.48	4.51	4.52
query36	0.66	0.47	0.46
query37	0.18	0.16	0.15
query38	0.15	0.14	0.15
query39	0.05	0.04	0.03
query40	0.16	0.14	0.15
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 109.78 s
Total hot run time: 30.73 s
HappenLee
HappenLee approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

PR approved by at least one committer and no changes requested.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 3, 2024

PR approved by anyone and no changes requested.
@yiguolei yiguolei merged commit 8a64e8f into apache:master Jun 3, 2024
27 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Jun 3, 2024
@zhangstar333 @Doris-Extras
[improve](session) print more error msg when set a wrong session vari…
a086111 
…able name (#35775)

## Proposed changes
when set a wrong session variable, eg:
mysql [(none)]>set enable_profileXXXXXXX=true;
ERROR 1228 (HY000): errCode = 2, detailMessage = Unknown system variable
'enable_profileXXXXXXX', the similar variables are {'enable_profile',
'enable_force_spill', 'enable_projection'}

<!--Describe your changes.-->
@yiguolei yiguolei mentioned this pull request Jun 3, 2024
Closed
dataroaring pushed a commit that referenced this pull request Jun 4, 2024
@zhangstar333 @dataroaring
[improve](session) print more error msg when set a wrong session vari…
77ce0c5 
…able name (#35775)

## Proposed changes
when set a wrong session variable, eg:
mysql [(none)]>set enable_profileXXXXXXX=true;
ERROR 1228 (HY000): errCode = 2, detailMessage = Unknown system variable
'enable_profileXXXXXXX', the similar variables are {'enable_profile',
'enable_force_spill', 'enable_projection'}

<!--Describe your changes.-->
seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
@zhangstar333 @seawinde
[improve](session) print more error msg when set a wrong session vari…
ac60c1e 
…able name (apache#35775)

## Proposed changes
when set a wrong session variable, eg:
mysql [(none)]>set enable_profileXXXXXXX=true;
ERROR 1228 (HY000): errCode = 2, detailMessage = Unknown system variable
'enable_profileXXXXXXX', the similar variables are {'enable_profile',
'enable_force_spill', 'enable_projection'}

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged reviewed
5 participants
@zhangstar333 @doris-robot @yiguolei @HappenLee @wm1581066