Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](coldhot) fix cannot cancel storage policy of partition #35874

Merged
merged 3 commits into from
Jun 17, 2024
Merged

[fix](coldhot) fix cannot cancel storage policy of partition #35874

merged 3 commits into from
Jun 17, 2024

Conversation

Yulei-Yang
Copy link
Contributor

@Yulei-Yang Yulei-Yang commented Jun 4, 2024 •
edited
Loading

Issue:
execute a stmt to cancel a partition's storage policy returns ok, but it does not work:
image
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.
@Yulei-Yang
Copy link
Contributor Author

run buildall
@doris-robot
Copy link

TPC-H: Total hot run time: 39914 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 51490ac8575b7a8eb407b72eb9672da4cfb0ce61, data reload: false

------ Round 1 ----------------------------------
q1	17621	4513	4405	4405
q2	2037	191	197	191
q3	10565	1146	1056	1056
q4	10198	790	785	785
q5	7534	2716	2727	2716
q6	222	138	143	138
q7	987	605	609	605
q8	9442	2081	2110	2081
q9	8936	6515	6414	6414
q10	9060	3767	3685	3685
q11	483	257	245	245
q12	531	220	222	220
q13	17765	2941	3002	2941
q14	275	215	226	215
q15	512	465	481	465
q16	515	378	381	378
q17	961	685	752	685
q18	8024	7518	7410	7410
q19	2745	1478	1429	1429
q20	671	322	309	309
q21	4928	3197	3801	3197
q22	403	344	349	344
Total cold run time: 114415 ms
Total hot run time: 39914 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4386	4340	4216	4216
q2	363	287	278	278
q3	2966	2776	2773	2773
q4	1864	1616	1574	1574
q5	5247	5234	5279	5234
q6	212	127	127	127
q7	2136	1723	1719	1719
q8	3166	3332	3293	3293
q9	8294	8323	8310	8310
q10	3918	3631	3690	3631
q11	584	492	488	488
q12	767	597	612	597
q13	17513	2972	2976	2972
q14	294	280	277	277
q15	524	474	485	474
q16	485	407	417	407
q17	1781	1476	1473	1473
q18	7675	7520	7467	7467
q19	2970	1461	1596	1461
q20	1969	1786	1784	1784
q21	4937	4759	4725	4725
q22	621	569	531	531
Total cold run time: 72672 ms
Total hot run time: 53811 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 170815 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 51490ac8575b7a8eb407b72eb9672da4cfb0ce61, data reload: false

query1	939	383	369	369
query2	6454	2524	2437	2437
query3	6656	210	213	210
query4	20112	17195	17287	17195
query5	4161	451	456	451
query6	248	163	160	160
query7	4594	303	305	303
query8	321	285	313	285
query9	8487	2470	2457	2457
query10	442	302	275	275
query11	10653	10139	10070	10070
query12	127	92	84	84
query13	1650	362	365	362
query14	9437	7677	7680	7677
query15	233	194	188	188
query16	7686	285	308	285
query17	1756	517	517	517
query18	1702	268	265	265
query19	198	154	156	154
query20	92	84	87	84
query21	206	133	128	128
query22	4375	4290	4050	4050
query23	33951	33135	33473	33135
query24	12009	2922	2774	2774
query25	661	349	359	349
query26	1733	158	159	158
query27	2883	336	326	326
query28	7495	2098	2113	2098
query29	1058	601	598	598
query30	280	147	152	147
query31	978	748	714	714
query32	93	51	56	51
query33	751	311	276	276
query34	943	495	485	485
query35	737	606	596	596
query36	1135	936	927	927
query37	174	70	72	70
query38	2867	2746	2694	2694
query39	871	785	828	785
query40	274	124	124	124
query41	55	51	50	50
query42	117	98	99	98
query43	594	563	538	538
query44	1195	725	747	725
query45	201	174	166	166
query46	1069	724	701	701
query47	1843	1778	1811	1778
query48	372	299	294	294
query49	1151	397	407	397
query50	785	404	406	404
query51	6952	6810	6753	6753
query52	111	89	93	89
query53	357	293	286	286
query54	989	485	460	460
query55	75	74	74	74
query56	278	263	255	255
query57	1153	1067	1049	1049
query58	250	266	241	241
query59	3521	3249	3281	3249
query60	289	269	264	264
query61	87	87	85	85
query62	651	443	430	430
query63	315	283	283	283
query64	9797	2278	1690	1690
query65	3217	3118	3112	3112
query66	1331	319	328	319
query67	15349	14899	14940	14899
query68	4591	558	549	549
query69	447	311	307	307
query70	1103	1067	1121	1067
query71	417	282	281	281
query72	7134	2709	2513	2513
query73	754	328	332	328
query74	5971	5544	5587	5544
query75	3453	2667	2647	2647
query76	2799	927	877	877
query77	507	296	291	291
query78	10368	9766	10161	9766
query79	2371	517	510	510
query80	1055	462	454	454
query81	585	217	220	217
query82	755	102	99	99
query83	231	166	163	163
query84	244	87	85	85
query85	1575	272	254	254
query86	537	320	324	320
query87	3249	3067	3081	3067
query88	4036	2443	2443	2443
query89	476	381	393	381
query90	1760	191	188	188
query91	124	97	97	97
query92	65	50	50	50
query93	1555	511	503	503
query94	1188	192	188	188
query95	421	326	334	326
query96	590	271	272	271
query97	3183	2981	3021	2981
query98	241	280	217	217
query99	1130	829	853	829
Total cold run time: 274441 ms
Total hot run time: 170815 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 30.53 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 51490ac8575b7a8eb407b72eb9672da4cfb0ce61, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.05
query3	0.23	0.05	0.06
query4	1.69	0.09	0.07
query5	0.50	0.48	0.50
query6	1.13	0.73	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.05
query9	0.54	0.51	0.49
query10	0.54	0.55	0.56
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.59	0.59	0.60
query14	0.80	0.77	0.78
query15	0.83	0.81	0.80
query16	0.37	0.36	0.36
query17	1.01	0.99	1.03
query18	0.22	0.24	0.23
query19	1.87	1.70	1.74
query20	0.02	0.01	0.01
query21	15.48	0.72	0.68
query22	4.57	6.76	1.94
query23	18.32	1.43	1.21
query24	1.90	0.23	0.21
query25	0.15	0.09	0.09
query26	0.27	0.18	0.18
query27	0.08	0.09	0.07
query28	13.31	1.01	0.98
query29	12.76	3.35	3.32
query30	0.25	0.06	0.06
query31	2.87	0.39	0.38
query32	3.29	0.47	0.47
query33	2.88	2.86	2.87
query34	17.16	4.39	4.46
query35	4.54	4.53	4.44
query36	0.64	0.46	0.46
query37	0.17	0.15	0.15
query38	0.15	0.15	0.15
query39	0.05	0.04	0.04
query40	0.16	0.15	0.15
query41	0.09	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.01 s
Total hot run time: 30.53 s
This was referenced Jun 5, 2024
Merged
Merged
lide-reed
lide-reed previously approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by at least one committer and no changes requested.
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by anyone and no changes requested.
xy720
xy720 reviewed Jun 5, 2024
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that canceling the partition's policy will not cause any other issues?
fe/fe-core/src/main/java/org/apache/doris/alter/Alter.java Outdated Show resolved Hide resolved
@xy720
Copy link
Member

xy720 commented Jun 5, 2024 •
edited
Loading

We should not cancel any storage migration policies after data migration.
There is a risk: the 'remote data size' has a certain delay.
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 5, 2024
@Yulei-Yang
Copy link
Contributor Author

run buildall
@doris-robot
Copy link

TPC-H: Total hot run time: 41396 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d13b6ce8bca07c588bed0362cc7297bda4c698a0, data reload: false

------ Round 1 ----------------------------------
q1	17622	4499	4330	4330
q2	2026	195	199	195
q3	10446	1169	1148	1148
q4	10186	884	752	752
q5	7488	2786	2740	2740
q6	223	139	140	139
q7	974	618	626	618
q8	9220	2202	2152	2152
q9	9532	6766	6768	6766
q10	9154	3917	3900	3900
q11	463	281	231	231
q12	451	228	228	228
q13	18243	3193	3238	3193
q14	268	207	233	207
q15	510	481	476	476
q16	496	396	393	393
q17	1011	683	693	683
q18	8435	7889	7909	7889
q19	3758	1401	1540	1401
q20	650	327	329	327
q21	5073	3289	4001	3289
q22	393	348	339	339
Total cold run time: 116622 ms
Total hot run time: 41396 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4597	4487	4447	4447
q2	371	260	276	260
q3	3141	2937	2995	2937
q4	1967	1617	1603	1603
q5	5423	5529	5554	5529
q6	229	130	134	130
q7	2191	1816	1757	1757
q8	3229	3403	3452	3403
q9	8719	8655	8715	8655
q10	4167	3862	3861	3861
q11	598	482	480	480
q12	773	592	619	592
q13	16471	3139	3154	3139
q14	299	276	272	272
q15	526	478	471	471
q16	488	446	451	446
q17	1829	1487	1496	1487
q18	8117	7866	7441	7441
q19	1747	1570	1655	1570
q20	3008	1784	1769	1769
q21	4959	4775	4724	4724
q22	725	538	542	538
Total cold run time: 73574 ms
Total hot run time: 55511 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 168853 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d13b6ce8bca07c588bed0362cc7297bda4c698a0, data reload: false

query1	907	377	369	369
query2	6443	2393	2392	2392
query3	6654	213	205	205
query4	20843	17056	17516	17056
query5	4126	444	454	444
query6	277	162	151	151
query7	4579	297	294	294
query8	313	269	282	269
query9	8432	2353	2315	2315
query10	428	295	266	266
query11	10606	10012	9993	9993
query12	132	86	84	84
query13	1636	367	359	359
query14	9373	6658	7116	6658
query15	249	195	185	185
query16	7133	262	262	262
query17	1024	520	522	520
query18	1924	272	283	272
query19	211	160	158	158
query20	94	92	93	92
query21	205	138	133	133
query22	4542	4206	4051	4051
query23	33942	33006	32959	32959
query24	11180	2840	2776	2776
query25	628	347	356	347
query26	1208	152	151	151
query27	3052	310	322	310
query28	7438	2043	2042	2042
query29	919	593	598	593
query30	287	146	151	146
query31	950	731	723	723
query32	94	51	51	51
query33	755	264	261	261
query34	1039	479	467	467
query35	765	615	620	615
query36	1106	934	936	934
query37	155	66	72	66
query38	2858	2748	2728	2728
query39	858	775	783	775
query40	208	122	125	122
query41	58	58	56	56
query42	120	95	96	95
query43	578	557	516	516
query44	1249	736	752	736
query45	195	163	165	163
query46	1076	699	723	699
query47	1847	1791	1810	1791
query48	370	296	304	296
query49	998	402	405	402
query50	781	377	387	377
query51	6833	6673	6655	6655
query52	105	92	93	92
query53	362	281	287	281
query54	837	469	464	464
query55	75	72	72	72
query56	279	246	253	246
query57	1133	1078	1073	1073
query58	243	268	240	240
query59	3254	3121	3154	3121
query60	292	276	264	264
query61	90	85	87	85
query62	644	449	451	449
query63	321	283	297	283
query64	8990	2195	1706	1706
query65	3159	3083	3199	3083
query66	1106	333	322	322
query67	15306	14964	15229	14964
query68	4519	550	553	550
query69	526	427	381	381
query70	1151	1113	1074	1074
query71	374	290	288	288
query72	7147	2703	2551	2551
query73	751	319	320	319
query74	5899	5483	5547	5483
query75	3378	2659	2603	2603
query76	2290	873	932	873
query77	447	300	291	291
query78	10267	9877	9718	9718
query79	2378	526	503	503
query80	937	443	445	443
query81	595	221	220	220
query82	1357	103	104	103
query83	238	172	172	172
query84	267	85	86	85
query85	1410	271	288	271
query86	486	315	376	315
query87	3252	3062	3040	3040
query88	4090	2443	2428	2428
query89	479	394	379	379
query90	1806	189	198	189
query91	125	94	98	94
query92	59	49	50	49
query93	2223	514	501	501
query94	1167	180	182	180
query95	397	311	304	304
query96	595	272	265	265
query97	3211	2998	3008	2998
query98	236	223	216	216
query99	1159	842	844	842
Total cold run time: 271090 ms
Total hot run time: 168853 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 31.23 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d13b6ce8bca07c588bed0362cc7297bda4c698a0, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.69	0.08	0.08
query5	0.51	0.47	0.51
query6	1.12	0.73	0.73
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.55	0.50	0.49
query10	0.53	0.56	0.54
query11	0.15	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.58	0.60
query14	0.78	0.77	0.79
query15	0.82	0.81	0.81
query16	0.36	0.35	0.37
query17	0.94	0.97	0.93
query18	0.23	0.21	0.27
query19	1.77	1.71	1.65
query20	0.01	0.00	0.01
query21	15.72	0.63	0.62
query22	4.35	6.25	2.99
query23	18.28	1.30	1.13
query24	1.87	0.20	0.23
query25	0.13	0.09	0.08
query26	0.26	0.17	0.17
query27	0.07	0.08	0.09
query28	13.35	1.02	0.98
query29	13.49	3.32	3.32
query30	0.24	0.05	0.05
query31	2.87	0.39	0.38
query32	3.31	0.48	0.46
query33	2.86	2.92	2.86
query34	17.08	4.39	4.46
query35	4.55	4.50	4.50
query36	0.68	0.46	0.46
query37	0.16	0.14	0.14
query38	0.15	0.14	0.12
query39	0.05	0.04	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.04
query42	0.06	0.05	0.04
query43	0.04	0.03	0.04
Total cold run time: 110.45 s
Total hot run time: 31.23 s
xy720
xy720 previously approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@xy720 xy720 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 13, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.
@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 14, 2024
@Yulei-Yang
Copy link
Contributor Author

run buildall
@doris-robot
Copy link

TPC-H: Total hot run time: 39744 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 69419d864a2665bac948b804820b86558ecfa41c, data reload: false

------ Round 1 ----------------------------------
q1	17606	4581	4299	4299
q2	2048	183	187	183
q3	10463	1137	1085	1085
q4	10209	743	780	743
q5	7464	2653	2572	2572
q6	220	138	136	136
q7	972	615	591	591
q8	9234	2086	2073	2073
q9	8710	6505	6494	6494
q10	8895	3723	3723	3723
q11	468	237	239	237
q12	488	229	216	216
q13	17767	2982	2974	2974
q14	275	231	224	224
q15	517	468	469	468
q16	502	376	367	367
q17	965	734	669	669
q18	8108	7365	7396	7365
q19	7312	1479	1494	1479
q20	648	314	316	314
q21	4958	3194	3839	3194
q22	387	342	338	338
Total cold run time: 118216 ms
Total hot run time: 39744 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4374	4217	4211	4211
q2	362	279	271	271
q3	2991	2943	2847	2847
q4	1963	1674	1729	1674
q5	5526	5495	5463	5463
q6	218	136	129	129
q7	2213	1875	1861	1861
q8	3312	3456	3420	3420
q9	8762	8787	8809	8787
q10	4158	3700	3806	3700
q11	613	509	489	489
q12	829	624	633	624
q13	15897	3138	3159	3138
q14	303	283	282	282
q15	532	486	510	486
q16	486	442	430	430
q17	1843	1508	1516	1508
q18	8023	7920	7861	7861
q19	1881	1762	1631	1631
q20	3031	1888	1855	1855
q21	5200	4951	4629	4629
q22	602	580	562	562
Total cold run time: 73119 ms
Total hot run time: 55858 ms
@doris-robot
Copy link

TPC-DS: Total hot run time: 173975 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 69419d864a2665bac948b804820b86558ecfa41c, data reload: false

query1	928	384	389	384
query2	6431	2356	2228	2228
query3	6629	208	219	208
query4	19700	17293	17257	17257
query5	3608	474	452	452
query6	237	157	160	157
query7	4581	297	295	295
query8	305	301	293	293
query9	8390	2413	2394	2394
query10	561	307	297	297
query11	10595	10221	10112	10112
query12	122	90	89	89
query13	1653	369	386	369
query14	10008	7591	7569	7569
query15	228	193	185	185
query16	7746	265	254	254
query17	1934	532	498	498
query18	1920	272	264	264
query19	186	148	146	146
query20	90	81	82	81
query21	213	134	124	124
query22	4347	4226	4049	4049
query23	33517	33540	33427	33427
query24	10745	2984	2882	2882
query25	587	365	376	365
query26	711	153	149	149
query27	2269	321	323	321
query28	5888	2131	2111	2111
query29	884	640	610	610
query30	255	150	156	150
query31	965	770	749	749
query32	96	54	54	54
query33	717	303	302	302
query34	866	508	478	478
query35	748	645	703	645
query36	1123	947	954	947
query37	140	72	71	71
query38	2947	2828	2824	2824
query39	890	863	841	841
query40	210	132	128	128
query41	56	51	52	51
query42	116	103	103	103
query43	584	537	557	537
query44	1078	729	724	724
query45	197	163	161	161
query46	1056	711	729	711
query47	1881	1809	1788	1788
query48	358	289	288	288
query49	815	400	402	400
query50	762	384	384	384
query51	6754	6671	6584	6584
query52	101	112	87	87
query53	356	289	279	279
query54	881	441	440	440
query55	72	71	70	70
query56	280	253	256	253
query57	1158	1016	1039	1016
query58	240	226	255	226
query59	3760	3091	3131	3091
query60	291	261	283	261
query61	90	87	86	86
query62	631	463	436	436
query63	317	279	290	279
query64	8851	2205	1720	1720
query65	3242	3132	3124	3124
query66	780	321	322	321
query67	15431	15079	15042	15042
query68	5561	536	534	534
query69	623	439	390	390
query70	1125	1147	1091	1091
query71	464	263	262	262
query72	7460	5383	5279	5279
query73	773	315	317	315
query74	5950	5514	5555	5514
query75	3715	2639	2725	2639
query76	3194	972	876	876
query77	596	293	294	293
query78	10347	10061	10145	10061
query79	2253	508	515	508
query80	899	460	450	450
query81	561	217	224	217
query82	966	101	100	100
query83	261	161	162	161
query84	231	87	84	84
query85	1315	283	271	271
query86	465	321	312	312
query87	3320	3108	3076	3076
query88	3532	2336	2319	2319
query89	466	383	385	383
query90	1700	192	191	191
query91	127	99	99	99
query92	64	48	51	48
query93	1499	511	492	492
query94	1085	184	245	184
query95	402	304	309	304
query96	583	274	263	263
query97	3227	3021	3068	3021
query98	221	205	198	198
query99	1118	819	846	819
Total cold run time: 268211 ms
Total hot run time: 173975 ms
@doris-robot
Copy link

ClickBench: Total hot run time: 29.63 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 69419d864a2665bac948b804820b86558ecfa41c, data reload: false

query1	0.04	0.03	0.03
query2	0.09	0.04	0.04
query3	0.24	0.05	0.05
query4	1.67	0.07	0.08
query5	0.59	0.47	0.49
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.05	0.04
query9	0.52	0.48	0.49
query10	0.53	0.56	0.54
query11	0.16	0.12	0.12
query12	0.14	0.11	0.12
query13	0.60	0.58	0.60
query14	0.78	0.79	0.78
query15	0.82	0.80	0.80
query16	0.35	0.37	0.35
query17	0.94	0.95	0.95
query18	0.21	0.22	0.26
query19	1.74	1.72	1.63
query20	0.01	0.01	0.01
query21	15.40	0.65	0.65
query22	4.68	8.11	1.30
query23	18.26	1.23	1.17
query24	2.11	0.22	0.24
query25	0.15	0.09	0.08
query26	0.27	0.18	0.18
query27	0.07	0.09	0.08
query28	13.21	1.03	1.00
query29	12.60	3.30	3.26
query30	0.26	0.06	0.05
query31	2.87	0.39	0.38
query32	3.25	0.48	0.47
query33	2.84	2.89	2.92
query34	17.12	4.41	4.42
query35	4.49	4.45	4.48
query36	0.65	0.46	0.45
query37	0.19	0.15	0.14
query38	0.15	0.14	0.14
query39	0.04	0.04	0.03
query40	0.18	0.14	0.15
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.05	0.04	0.04
Total cold run time: 109.63 s
Total hot run time: 29.63 s
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 14, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.
@Yulei-Yang
Copy link
Contributor Author

run p0
4 similar comments
@Yulei-Yang
Copy link
Contributor Author

run p0
@Yulei-Yang
Copy link
Contributor Author

run p0
@Yulei-Yang
Copy link
Contributor Author

run p0
@Yulei-Yang
Copy link
Contributor Author

run p0
lide-reed
lide-reed approved these changes Jun 16, 2024
View reviewed changes
Copy link
Contributor

@lide-reed lide-reed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@xy720 xy720 merged commit e0dbc3e into apache:master Jun 17, 2024
27 of 30 checks passed
@Yulei-Yang Yulei-Yang deleted the fix_cancel_partition_storage_policy branch June 17, 2024 03:34
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@Yulei-Yang @dataroaring
[fix](coldhot) fix cannot cancel storage policy of partition (#35874)
250de1b 
Fix an issue that executing a stmt to cancel a partition's storage policy returns ok, but it does not work.
@morningman morningman mentioned this pull request Jun 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.4-merged reviewed
5 participants
@Yulei-Yang @doris-robot @xy720 @lide-reed @morningman