-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](nereids) fix merge aggregate rule, rules should not have mutable members #36145
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add test case. add description about the root cause of bug and the PR intro it
TPC-H: Total hot run time: 40834 ms
|
TPC-DS: Total hot run time: 173293 ms
|
ClickBench: Total hot run time: 31.11 s
|
run buildall |
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40126 ms
|
TPC-DS: Total hot run time: 173666 ms
|
ClickBench: Total hot run time: 30.39 s
|
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/MergeAggregate.java
Outdated
Show resolved
Hide resolved
run buildall |
run feet |
run feut |
run performance |
TPC-H: Total hot run time: 40076 ms
|
TPC-DS: Total hot run time: 169468 ms
|
ClickBench: Total hot run time: 31.23 s
|
PR approved by at least one committer and no changes requested. |
…e members (apache#36145) This bug is induced by apache#31811. The innerAggExprIdToAggFunc was a member of MergeAggregate, which was wrong. Because rules like MergeAggregate are single instances, same rules applied to different sub-plans will affect each other. This pr changes innerAggExprIdToAggFunc to a local variable, fixes this bug. No regression use case was added because it’s not a problem that will definitely reoccur and requires the same rule to be applied to multiple plans at the same time.
…e members (#36145) This bug is induced by #31811. The innerAggExprIdToAggFunc was a member of MergeAggregate, which was wrong. Because rules like MergeAggregate are single instances, same rules applied to different sub-plans will affect each other. This pr changes innerAggExprIdToAggFunc to a local variable, fixes this bug. No regression use case was added because it’s not a problem that will definitely reoccur and requires the same rule to be applied to multiple plans at the same time.
This bug is induced by #31811.
The innerAggExprIdToAggFunc was a member of MergeAggregate, which was wrong. Because rules like MergeAggregate are single instances, same rules applied to different sub-plans will affect each other. This pr changes innerAggExprIdToAggFunc to a local variable, fixes this bug.
No regression use case was added because it’s not a problem that will definitely reoccur and requires the same rule to be applied to multiple plans at the same time.