Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](rpc) fix transfer large data and enable transfer_large_data_by_brpc by default #35770 #36169

Merged

Conversation

liaoxin01
Copy link
Contributor

cherry pick from #35770

…brpc by default (apache#35770)

## Proposed changes

Issue Number: close #xxx

when send large data by rpc,load will report the following error:
```
add batch req success but status isn't ok, err: [INTERNAL_ERROR]PStatus: (172.200.0.1)[INTERNAL_ERROR]fail to add batch in load channel. unknown load_id=0000000000000000-0000000000000000.

```

The maximum length of protobuf is 2GB. When it exceeds 2GB, we will use
the brpc HTTP method. However, the block data was not removed during
encoding, resulting in protobuf exceeding the length and encoding
failure.

The config of transfer_large_data_by_brpc was enabled by default on
branch-2.0, so we also enable it on master.
@liaoxin01
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (9125/25142)
Line Coverage: 27.78% (74227/267149)
Region Coverage: 26.72% (38313/143366)
Branch Coverage: 23.41% (19411/82916)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9af434dd3fba596193d1505c0901fed439abd953_9af434dd3fba596193d1505c0901fed439abd953/report/index.html

@dataroaring dataroaring merged commit d1eb917 into apache:branch-2.1 Jun 12, 2024
20 of 22 checks passed
@morningman morningman mentioned this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants