[fix](nereids)change the decimal's precision and scale for cast(xx as decimal) #36316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
TPC-H: Total hot run time: 39975 ms |
TPC-DS: Total hot run time: 171985 ms |
ClickBench: Total hot run time: 31.29 s |
|
run buildall |
TPC-H: Total hot run time: 40257 ms |
TPC-DS: Total hot run time: 171714 ms |
ClickBench: Total hot run time: 30.43 s |
starocean999
force-pushed
the
nereids_1019
branch
from
2405c30
to
a469643
Compare
|
run compile |
starocean999
force-pushed
the
nereids_1019
branch
from
a469643
to
fdab6d5
Compare
|
run buildall |
starocean999
force-pushed
the
nereids_1019
branch
from
fdab6d5
to
702066b
Compare
|
run buildall |
TPC-H: Total hot run time: 39778 ms |
TPC-DS: Total hot run time: 174152 ms |
ClickBench: Total hot run time: 30.52 s |
morrySnow
approved these changes
Jun 19, 2024
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
englefly
approved these changes
Jun 19, 2024
morrySnow
pushed a commit
that referenced
this pull request
Jun 20, 2024
… decimal) (#36540) pick from master #36316 expression cast( xx as decimal )'s datatype maybe decimalv3 or decimalv2 depending on enable_decimal_conversion value in fe conf file. if enable_decimal_conversion is true, the datatype is decimalv3(9, 0), but the datatype was decimalv3(38, 9) in 2.0 releases. So this pr change the datatype same as 2.0 releases to keep the behavior consistent.
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
… decimal) (#36316) expression cast( xx as decimal )'s datatype maybe decimalv3 or decimalv2 depending on enable_decimal_conversion value in fe conf file. if enable_decimal_conversion is true, the datatype is decimalv3(9, 0), but the datatype was decimalv3(38, 9) in 2.0 releases. So this pr change the datatype same as 2.0 releases to keep the behavior consistent.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expression cast( xx as decimal )'s datatype maybe decimalv3 or decimalv2 depending on enable_decimal_conversion value in fe conf file. if enable_decimal_conversion is true, the datatype is decimalv3(9, 0), but the datatype was decimalv3(38, 9) in 2.0 releases. So this pr change the datatype same as 2.0 releases to keep the behavior consistent.
Proposed changes
Issue Number: close #xxx