Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.1](auto-partition) Fix auto partition load failure in multi replica #36586

Merged
merged 2 commits into from
Jun 20, 2024

Conversation

zclllyybb
Copy link
Contributor

kaijchen and others added 2 commits June 20, 2024 14:23
…er (apache#35287) (apache#35630)

## Proposed changes

Change `use_cnt` mechanism for incremental (auto partition) channels and
streams, it's now dynamically counted.
Use `close_wait()` of regular partitions as a synchronize point to make
sure all sinks are in close phase before closing any incremental (auto
partition) channels and streams.
Add dummy (fake) partition and tablet if there is no regular partition
in the auto partition table.

Backport apache#35287

Co-authored-by: zhaochangle <zhaochangle@selectdb.com>
apache#36344)

One sender may incremental_open `tablets_channel` many times. but only
close one time. so don't count num_senders duplicated for one sender
instance.
@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zclllyybb
Copy link
Contributor Author

run buildall

Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.29% (9136/25172)
Line Coverage: 27.78% (74302/267500)
Region Coverage: 26.70% (38335/143579)
Branch Coverage: 23.40% (19419/82994)
Coverage Report: http://coverage.selectdb-in.cc/coverage/fc81e5324e8850fdce59949a42e2e415c076fb5e_fc81e5324e8850fdce59949a42e2e415c076fb5e/report/index.html

@morningman morningman merged commit bd47d5a into apache:branch-2.1 Jun 20, 2024
19 of 22 checks passed
@morningman morningman mentioned this pull request Jun 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants