Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simulate packet loss #755

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Simulate packet loss #755

wants to merge 1 commit into from

Conversation

dsseng
Copy link

@dsseng dsseng commented Oct 20, 2022

Useful when testing debugging UDP-based software like realtime audio streaming, simulates non-ideal network conditions.
@dsseng
Simulate packet loss
8c05b44 
Useful when testing UDP-based software like audio streaming, simulates non-ideal network conditions
@fklassen
Copy link
Member

fklassen commented Jan 1, 2023

This is an option that should be in tcpreplay-edit not tcpreplay. There are other issues that this PR would introduce that would make me reluctant to accept this. This includes breaking dual-interface sends, tcpprep etc. Also, there are no tests included.

I'll shelve this for now, but may reconsider if more work is done.
@fklassen fklassen added the shelved Will not be addressed in foreseeable future label Jan 1, 2023
@dsseng
Copy link
Author

dsseng commented Jan 1, 2023

Yes, it would make more sense in tcpreplay-edit. Basically the work here was done for a simple test and then sent for upstreaming.
@fklassen
Copy link
Member

fklassen commented Jan 2, 2023

PR's are always welcome. I'll have a look at it when I work on an enhancement release (4.5).
@dsseng
Copy link
Author

dsseng commented Jan 2, 2023

Great, thank you for your effort!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
shelved Will not be addressed in foreseeable future
2 participants
@dsseng @fklassen