Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sam): support java21 Lambda runtime #4382

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(sam): support java21 Lambda runtime #4382

wants to merge 2 commits into from

Conversation

justinmk3
Copy link
Contributor

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@justinmk3 justinmk3 requested a review from a team as a code owner February 5, 2024 15:40
@justinmk3
Copy link
Contributor Author

justinmk3 commented Feb 5, 2024 •
edited
Loading

/runintegrationtests
@justinmk3
Copy link
Contributor Author

justinmk3 commented Feb 5, 2024 •
edited
Loading 

[Container] 2024/02/05 15:42:24.042117 Running command add-apt-repository -y ppa:deadsnakes/ppa
Traceback (most recent call last):
  File "/usr/bin/add-apt-repository", line 364, in <module>
    sys.exit(0 if addaptrepo.main() else 1)
  ...
  File "/usr/lib/python3/dist-packages/lazr/restfulclient/_browser.py", line 429, in _request
    raise error
lazr.restfulclient.errors.ServerError: HTTP Error 503: Service Unavailable
Response headers:
---
-content-encoding: gzip
connection: close
content-length: 2155
content-type: text/html
date: Mon, 05 Feb 2024 15:48:22 GMT
server: Apache/2.4.41 (Ubuntu)
status: 503
vary: Accept-Encoding
---
Response body:
---
b'... <title>Launchpad is temporarily unavailable<

See #4388
justinmk3
justinmk3 commented Feb 5, 2024
View reviewed changes
src/testInteg/sam.test.ts Outdated
debugSessionType: 'java',
language: 'java',
dependencyManager: 'gradle',
vscodeMinimum: '1.80.0',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added an integ test. Also verified in codecatalyst dev env.
@justinmk3
Copy link
Contributor Author

justinmk3 commented Feb 5, 2024 •
edited
Loading

/retrybuild
@justinmk3
feat(sam): support java21 Lambda runtime
ba7424f
@justinmk3
fix(ci): skip before/after of skipped integ tests
7b9f1a1 
Problem:
The before() setup runs even if the test was skipped for the current
version of vscode.

Solution:
Skip earlier. Improve the log report.

    DebugSessions seen in this run:
        SKIPPED (vscode 1.68.0 < 1.77.0): python 3.10 (ZIP)
        SKIPPED (vscode 1.68.0 < 1.78.0): python 3.11 (ZIP)
        SKIPPED (vscode 1.68.0 < 1.78.0): python 3.12 (ZIP)
        SKIPPED (vscode 1.68.0 < 1.80.0): dotnet6 (ZIP)
        SKIPPED (vscode 1.68.0 < 1.80.0): java8.al2 (Maven ZIP)
        SKIPPED (vscode 1.68.0 < 1.80.0): java11 (Gradle ZIP)
        SKIPPED (vscode 1.68.0 < 1.80.0): java17 (Gradle ZIP)
        SKIPPED (vscode 1.68.0 < 1.80.0): java21 (Gradle ZIP)
        SKIPPED (vscode 1.68.0 < 1.77.0): python 3.10 (ZIP)
        SKIPPED (vscode 1.68.0 < 1.78.0): python 3.11 (ZIP)
        SKIPPED (vscode 1.68.0 < 1.78.0): python 3.12 (ZIP)
        SKIPPED (vscode 1.68.0 < 1.80.0): java8.al2 (Gradle Image)
        SKIPPED (vscode 1.68.0 < 1.80.0): java11 (Maven Image)
        SKIPPED (vscode 1.68.0 < 1.80.0): java17 (Maven Image)
        SKIPPED (vscode 1.68.0 < 1.80.0): dotnet6 (Image)
        scenario 0.a EXIT  api/nodejs16.x (ZIP): test-config-0 (exited immediately)
        scenario 0.t EXIT  template/nodejs16.x (ZIP): test-config-0 (exited immediately)
        scenario 1.a EXIT  api/nodejs18.x (ZIP): test-config-1 (exited immediately)
        scenario 1.t EXIT  template/nodejs18.x (ZIP): test-config-1 (exited immediately)
        scenario 10.a EXIT  api/nodejs16.x (Image): test-config-10 (exited immediately)
        scenario 10.t EXIT  template/nodejs16.x (Image): test-config-10 (exited immediately)
        scenario 11.a EXIT  api/nodejs18.x (Image): test-config-11 (exited immediately)
        scenario 11.t EXIT  template/nodejs18.x (Image): test-config-11 (exited immediately)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@justinmk3 @hayemaxi