Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] - Amazon Q Code Transform: Fix job loss on restart #5014

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

[WIP] - Amazon Q Code Transform: Fix job loss on restart #5014

wants to merge 8 commits into from

Conversation

arangatang
Copy link
Contributor

@arangatang arangatang commented May 17, 2024 •
edited
Loading

Problem

Currently we only store the latest job details and this is lost on restart. This means customer job results are lost irrevocably.

Solution

  1. Store relevant job details in vsCodes workspace state
  2. Add buttons to show diff / summary in job history panel
  3. Make job history panel display multiple entries
  4. Add expireOn field to indicate when job details should be removed
  5. Remove expired job details and delete associated job artifacts from disk on extension start

TODOs

  1. Changelog
  2. Avoid deleting artifacts on accept / reject (so that job data stays)
  3. Change so we display diff as in normal flow instead of displaying the patch file when clicking view patch

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@arangatang arangatang self-assigned this May 17, 2024
@arangatang arangatang requested review from a team as code owners May 17, 2024 15:32
@arangatang arangatang marked this pull request as draft May 17, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@arangatang