build(core): kill 8080 port before serving vue files #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinmk3
reviewed
Jun 6, 2024
| @@ -4069,6 +4069,7 @@ | |||
| "immutable": "^4.3.0", | |||
| "js-yaml": "^4.1.0", | |||
| "jsonc-parser": "^3.2.0", | |||
| "kill-port": "^2.0.1", | |||
There was a problem hiding this comment.
This should be a devDependency, it's not necessary for the production build.
But not sure this is worth adding a dependency for. Can we choose a different port instead of 8080? Killing the "port" seems wrong. Why isn't the task that we started being killed properly?
There was a problem hiding this comment.
Why the Vue server process doesn't get killed isn't clear. It just happens to not stop sometimes. This has sometimes happened with the web mode server as well. So I think we can reuse this there as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AWS Toolkits and Amazon Q extension expects the web view to be served at
8080port. When there is a existing process,vueprocess starts at8081and so on ports. When this happens, webview doesn't always serve the latest code hampering developer productivity.Solution
8080port before startingserveVueCoreprocess. This ensureswebviewis always served on port 8080.kill-portin cross platform.License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.