Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamoDB Initial Changes #5241

Closed
wants to merge 11 commits into from
Closed

DynamoDB Initial Changes #5241

wants to merge 11 commits into from

Conversation

Lokesh1302
Copy link

Problem

Solution

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
jpinkney-aws
jpinkney-aws reviewed Jun 27, 2024
View reviewed changes
Copy link
Contributor

@jpinkney-aws jpinkney-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice start!
packages/core/src/dynamoDb/activation.ts Outdated Show resolved Hide resolved
packages/core/src/dynamoDb/explorer/dynamoDbInstanceNode.ts Outdated Show resolved Hide resolved
packages/core/src/shared/clients/dynamoDbClient.ts Outdated Show resolved Hide resolved
@Lokesh1302 Lokesh1302 marked this pull request as ready for review July 10, 2024 19:51
@Lokesh1302 Lokesh1302 requested a review from a team as a code owner July 10, 2024 19:51
@Lokesh1302 Lokesh1302 requested review from a team as code owners July 11, 2024 19:01
Revert "Addressing code review comments"
de4674d 
This reverts commit 4a74a2d.

reverting the commit
@Lokesh1302 Lokesh1302 closed this Jul 11, 2024
@Lokesh1302 Lokesh1302 deleted the lodogga/develop branch July 11, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@Lokesh1302 @justinmk3 @jpinkney-aws