fix: disable unused trigger for comment responder #48976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daler
approved these changes
Jul 5, 2024
|
It just ran from these checks completing in this PR (with my user mentioned). So, that explains why it's running. GitHub Actions shows it against the master head commit for some reason, which is confusing. That doesn't change the fact that there's no reason for this to run just to skip all the jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment responder is repeatedly triggering for no reason. I'm not sure if it's caught in a loop of triggering itself, but it keeps running against the latest commit on master. The
check_runtrigger doesn't pass the conditions for any of the bot jobs as of 3 years ago (see comment on line 11).It's showing up in GitHub Actions as "completed by ghost". I'm not sure if that's because the latest commit was authored by more than one person. Maybe a GitHub Actions bug. In any case, there is no reason to keep this going.