Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import of tmodel fails #13

Open
timmccubbin opened this issue Nov 22, 2020 · 2 comments �� Fixed by #14
Open

Import of tmodel fails #13

timmccubbin opened this issue Nov 22, 2020 · 2 comments · Fixed by #14

Comments

@timmccubbin
Copy link
Collaborator

Importing tmodel fails at from .thermo_constants import * at line 20: params = CCModelParameters.from_quilt() with the error message that CCModelParameters has no attribute 'from_quilt'. It appears that an update on the Equilibrator side may have changed/removed some features.
@vishnumahamkali
Copy link
Collaborator

It looks like component contribution recent update to 0.4.0 modified training model parameters. I am modifying the package dependency requirements equilibrator-api==0.3.2b7 and component_contribution==0.3.2. This probably works for now. @Midnighter what do you suggest ?
@vishnumahamkali vishnumahamkali self-assigned this Nov 22, 2020
vishnumahamkali added a commit that referenced this issue Nov 22, 2020
@vishnumahamkali
Import of tmodel fails
469aaf8 
Fixes #13 setting the equilibrator-api and component_contribution dependencies to 0.3.2
@vishnumahamkali vishnumahamkali mentioned this issue Nov 22, 2020
Merged
@vishnumahamkali vishnumahamkali removed their assignment Nov 22, 2020
@Midnighter
Copy link
Collaborator

Sounds like a good solution. I will soon focus more on equilibrator and can then also work on synchronizing the latest API here in tmfa.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@Midnighter @vishnumahamkali @timmccubbin