Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Query parameters #293

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

ofostier
Copy link
Contributor

@ofostier ofostier commented Jun 6, 2024

Regarding the request 283.
I add the query parameters management.

@ofostier
Copy link
Contributor Author

ofostier commented Jun 6, 2024

Query parameters are :
ssid = string
password = string
encryptionMode = string WPA / WPA2-EAP / WEP
eapMethod = string default 'PWD'
eapIdentity = string
hidePassword = string true/false
hiddenSSID = string true/false
portrait = string true/false
additionalCards = number
hideTip = string true/false
lng = all available language id in translation.js file

@ofostier ofostier closed this Jun 6, 2024
@ofostier ofostier reopened this Jun 6, 2024
@millette
Copy link

Perhaps it would be best to use the #hash instead of query parameters since the #hash doesn't reach the server.

Related to #283 (proper issue id links the pr accrross github).

@bndw
Copy link
Owner

bndw commented Jun 12, 2024

@millette Good callout. I don't want this webapp to send private information to any server and query params would certainly do that. Using a hash instead is a clever workaround.

Further, I think the approach in this PR needs a little more thought. I don't love the implementation. The core logic should be factored out into a function and not jammed inline.

@ofostier
Copy link
Contributor Author

Hi,
Thanks to make me brainstorming on this
I reviewed the logic and implementation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants