Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give up making attemps to test domain in case of an error #172

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxpain
Copy link

@maxpain maxpain commented Feb 20, 2024

If a website is unavailable, then we didn't bypass a DPI, so it makes no sence to do additional attempts.
This speedups checks when an ISP have load balancing or multiple DPIs and we repeat the test, for example, 20 times.

In other words: We should do additional attempts only if a domain is available.

@bol-van
Copy link
Owner

bol-van commented Feb 20, 2024

Full run helps to estimate success/fail rate
Curl tests are not 100% perferct. Sometimes website itself react abnormally or doesnt like hammering

@maxpain
Copy link
Author

maxpain commented Feb 20, 2024

Full run helps to estimate success/fail rate Curl tests are not 100% perferct. Sometimes website itself react abnormally or doesnt like hammering

Then I think we need to provide two more options:

  • Fail threshold
  • Success threshold
@bol-van
Copy link
Owner

bol-van commented Feb 20, 2024

I don't think these additional complications worth it
Most people run with 1 attempt. Those who run more they won't run more than 10 attempts because it's useless in most cases.
It's not hard to count one single test. Totals for multiple tests are meaningless

@maxpain
Copy link
Author

maxpain commented Feb 20, 2024

In my case my ISP have load balancing and 10 attempts sometimes aren't enough, because all attempts are produced so fast and don't even blocked by DPI.

@bol-van
Copy link
Owner

bol-van commented Feb 21, 2024

Use tee command like this :

./blockcheck.sh | tee /tmp/blockcheck.txt
then examine /tmp/blockcheck.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants