Add local and head manifest schemas #2379
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The generateSchemaId function in generate-schema-id.ts has been updated to accept an options object as a parameter, allowing for more flexibility in generating the schema ID. This change improves the maintainability and extensibility of the code.
The manifest tests in index.test.ts have been updated to use relative schema paths instead of absolute paths. This change improves the portability and maintainability of the tests.
|
Mearman
requested review from
aomarks and
paullewis
and removed request for
aomarks
paullewis
requested changes
Jul 12, 2024
| const readSchemaFile = fs.readFileSync(ABSOLUTE_SCHEMA_PATH, "utf-8"); | ||
| const parsedSchema = JSON.parse(readSchemaFile); | ||
| const validate = await ajv.compileAsync(parsedSchema); | ||
| // const readSchemaFile = fs.readFileSync(ABSOLUTE_SCHEMA_PATH, "utf-8"); |
There was a problem hiding this comment.
super-nit: please remove the comments
| if (errors) { | ||
| throw new Error(`errors: ${JSON.stringify(errors, null, 2)}`); | ||
| const schemaPaths = [ | ||
| // { path: ABSOLUTE_SCHEMA_PATH }, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.