Fixed repetitions in OpenSCENARIO (Fixes #443) #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianoboril
force-pushed
the
fix/repetitions
branch
2 times, most recently
from
f97b10b
to
82aa03b
Compare
Repetitions in OpenSCENARIO were not properly working. Reworked the repetition handling by three major changes: - Not copy py_tree elements, this will cause problems due to references in Python - Replaced get_py_tree_path with get_xml_path, as the first was not working properly - Avoid using ":" in py_tree behavior names, as this may break py_trees Change-Id: I7829106136cd6c20e6863d1f424fbc600030bf13
- Default pedestrians are now supported, i.e. if the pedestrian is not known, a default walker is used. - Fixed InitSpeed bug for OpenSCENARIO, which caused an Exception because of unknown actor id. Change-Id: I6a62de3314d90757f3990b40beb46e693a8a0ef7
fabianoboril
force-pushed
the
fix/repetitions
branch
from
82aa03b
to
20154e4
Compare
- Removed lock mechanism in ScenarioManager - Moved SignalHandler to ScenarioRunner. - stop_scenario() in ScenarioManager odes no longer perform cleanup. This is now handled by cleanup() Change-Id: I9716d1bbb921a65ff8a8a9cf78912cf9708de1f1
fabianoboril
force-pushed
the
fix/repetitions
branch
from
d7f8020
to
80b0793
Compare
fpasch
approved these changes
Feb 10, 2020
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repetitions in OpenSCENARIO were not properly working. Reworked the repetition
handling by three major changes:
Fixes #443
This change is