Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat( default behaviour ): pause notification kill-duration on mouseover then resume on mouseleave #109

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat( default behaviour ): pause notification kill-duration on mouseover then resume on mouseleave #109

wants to merge 2 commits into from

Conversation

AbrahemAlhofe
Copy link
Contributor

No description provided.

@AbrahemAlhofe
feat( default behaviour ): pause notification kill-duration on mouseo…
1189430 
…ver and resume on mouseleave

    - add "should pause on mouseover" test
    - add "EventListener", "Timer" utilities' classes
    - public "NotyfNotification.triggerEvent"
        | to make "NotyfView" trigger "mouseover" event on "NotyfNotification"
    - add "NotyfEvent.MouseOver"
    - add "NotyfEvent.MouseLeave"
    - update "Notyf._pushNotification"
        = pause "NotyfNotification" timer and resume timer on "mouseleave"
        = remove "NotyfNotification" on timer "finished" event
    - trigger "mouseover" event on "NotyfNotification" by "NotyfView"
    - trigger "mouseleave" event on "NotyfNotification" by "NotyfView"

close caroso1222#110
@AbrahemAlhofe AbrahemAlhofe changed the title feat( default behaviour ): pause notification kill-duration on mouseover and resume on mouseleave Jun 15, 2021
@AbrahemAlhofe
refactor( EventListener ): improve EventListener types
f892ff7 
    - change name of `EventListener" to `EventEmitter`
    - add `EventMap` generic
        | `EventMap` includes events and their payloads
    - make `EventEmitter.targgetEvent` method public
    - make `Timer` passes their event map to `EventEmitter`
    - make `NotyfNotification` extends `EventEmitter`
    - pass `target` as the target property on event "dimiss" and event "click" on `Notyf`
    - pass `notification` as the target property to events "mouseover" and "mouseleave" on `NotyfView`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@AbrahemAlhofe