Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NNF of empty conjunction and disjunction. #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix NNF of empty conjunction and disjunction. #35

wants to merge 1 commit into from

Conversation

DrJosh9000
Copy link

In the existing code, and(True).Eval() = true, but and(True).nnf().Eval() = false. The nnf method elides True, leaving an
empty conjunction. So the problem is the choice of False for the NNF of empty conjunction. The dual bug existed for disjunction.
@DrJosh9000
Fix NNF of empty conjunction and disjunction.
2a5c677 
In the existing code, and(True).Eval() = true, but
and(True).nnf().Eval() = false. The nnf method elides True, leaving an
empty conjunction. So the problem is the choice of False for the NNF
of empty conjunction. The dual bug existed for disjunction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant
@DrJosh9000