Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README misleading with "no-dependency library" line #109

Closed
curran opened this issue Aug 14, 2020 · 2 comments · Fixed by #110
Closed

README misleading with "no-dependency library" line #109

curran opened this issue Aug 14, 2020 · 2 comments · Fixed by #110

Comments

@curran
Copy link
Contributor

curran commented Aug 14, 2020

When I see "no-dependency library", I expect an empty dependencies field in package.json. Suggest to remove the phrase "no-dependency library".
curran added a commit to curran/d3-delaunay that referenced this issue Aug 14, 2020
@curran
Remove no-dependency line. Closes d3#109
3f11339
@curran curran mentioned this issue Aug 14, 2020
Merged
@mbostock
Copy link
Member

It’s referring to usage in the browser: the d3-delaunay bundle includes delaunator, so you don’t have to load it to use it. But sure.
mbostock pushed a commit that referenced this issue Aug 14, 2020
@curran @mbostock
Remove no-dependency line. Closes #109
64451c2
@curran
Copy link
Contributor Author

curran commented Aug 14, 2020

Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@curran @mbostock