Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rollup and rollup-plugin-terser #121

Closed
martinfrances107 opened this issue Apr 14, 2021 · 2 comments
Closed

Update rollup and rollup-plugin-terser #121

martinfrances107 opened this issue Apr 14, 2021 · 2 comments

Comments

@martinfrances107
Copy link
Contributor

martinfrances107 commented Apr 14, 2021 •
edited
Loading

I have just enabled automated security audits on my github account and the bot reported a security warning for my local copy of d3-delaunay which I would like to fix upstream.

serialize-javascript has a high severity warning

which is pulled in as a result of our outdated use of rollup-plugin-terser

my proposal it we bump the major version of both rollup and rollup-plugin-terser

When I test locally every works smoothly... I am about to file a PR.

here is the diff of package.json

-    "rollup": "1",
+    "rollup": "^2.45.2",
     "rollup-plugin-node-resolve": "5",
-    "rollup-plugin-terser": "5"
+    "rollup-plugin-terser": "^7.0.2"
martinfrances107 added a commit to martinfrances107/d3-delaunay that referenced this issue Apr 14, 2021
@martinfrances107
Update rollup and rollup-plugin-terser d3#121
117faf1
@Fil
Copy link
Member

Fil commented Apr 21, 2021

Will be fixed by #113 or #115.
@martinfrances107
Copy link
Contributor Author

Thanks for taking a look at this ... and finding a solution.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@Fil @martinfrances107