[wip] Flat storage for cells. #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
On a 1 million random sample: # before
~/projects/voronator master* → node bench
delaunay: 1596.082ms
voronoi: 1477.480ms
# after
~/projects/voronator flat-cell* → node bench
delaunay: 1617.328ms
voronoi: 444.549msSo, if everything is correct, looks like a further 3x. 🎉 |
mourner
approved these changes
Mar 23, 2018
Fixes #27. Also improves Delaunay.from so that it more closely matches Array.from: the specified points can be an array-like object with a length property or an iterable; an optional this argument can be specified; and the x- and y-accessors are invoked with the element, index and object as arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24. Seems to work well?
TODO