Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Delaunator to v2 #26

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Upgrade Delaunator to v2 #26

merged 1 commit into from
Mar 23, 2018

Conversation

mourner
Copy link
Collaborator

@mourner mourner commented Mar 23, 2018

I converted Delaunator to a proper ES module now, so we can remove rollup-plugin-commonjs.
@mourner mourner requested a review from mbostock March 23, 2018 09:37
@mourner
Copy link
Collaborator Author

mourner commented Mar 23, 2018

@mbostock offtopic, is there a reason for d3 modules not to use any kind of CI like Travis or Circle? This would be very helpful for managing contributions. Adding linters like ESLint would help too.
@mbostock mbostock merged commit 2369b94 into master Mar 23, 2018
@mbostock mbostock deleted the upgrade-delaunator branch March 23, 2018 15:47
@mbostock
Copy link
Member

Would be happy to setup CircleCI and ESLint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@mourner @mbostock