Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to delaunator@3 #59

Closed
wants to merge 4 commits into from
Closed

upgrade to delaunator@3 #59

wants to merge 4 commits into from

Conversation

Fil
Copy link
Member

@Fil Fil commented May 21, 2019

fixes #50

Demos:

I had to disable the tests for outeredges, because I'm not using the same outeredges (but they do point to the same nodes).(fixed, see below)

fixes #50

note: I had to disable the tests for outeredges, because I'm not using the same outeredges (but they do point to the same nodes).
@Fil Fil mentioned this pull request May 21, 2019
Fil added 3 commits May 22, 2019 06:13
> hull[i-1] -i-> p --> hull[i+1] -o-> hull[i+2]
the outeredge for p = hull[i] is the inedge for hull[i+2]
@Fil
Copy link
Member Author

Fil commented May 22, 2019

I've now restored the outedges as they used to be; in the following schema:

hull[i-1] -in-> p --> hull[i+1] -out-> hull[i+2]

the outeredge for p = hull[i] is the inedge for hull[i+2]

But this is imho too complicated for what we want (to be able to compute the last neighbor of p when p is on the hull). We can do so with a much more readable hullIndex (see branch hullIndex and specifically cf26755).

So I'd be in favor of removing delaunay.outedges from the API and using hullIndex instead.

In any event, it's a major version change because delaunay.hull is not the linked chain of objects.

@Fil Fil mentioned this pull request May 22, 2019
@Fil
Copy link
Member Author

Fil commented May 22, 2019

superseded by #60

@Fil Fil closed this May 22, 2019
@Fil Fil deleted the delaunator3 branch May 24, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant