Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Delaunay and Voronoi for degenerate cases #64

Merged
merged 2 commits into from
Jun 20, 2019
Merged

Fix Delaunay and Voronoi for degenerate cases #64

merged 2 commits into from
Jun 20, 2019

Conversation

Fil
Copy link
Member

@Fil Fil commented May 24, 2019

For 0, 1, 2 points, and for collinear points:

  • returns the correct topology (neighbors, find)
  • returns the correct Voronoi cells (bounding box, half plane…)
  • resorts to deterministic jittering only in the case of multiple collinear points

Needs this change to Delaunator@3: Fil/delaunator@b968020 (Delaunator#47)

based on branch delaunator3 (#63).

fixes #50

removes delaunay.outedges from the API, replaced with the private _hullIndex
@Fil
Copy link
Member Author

Fil commented Jun 19, 2019

Now based on Delaunator@4. Should be released as d3-delaunay@5 as it removes delaunay.outedges from the API.

Fix Delaunay and Voronoi for degenerate cases

For 0, 1, 2 points, and for collinear points:
- returns the correct topology (neighbors, find)
- returns the correct Voronoi cells (bounding box, half plane…)
- resorts to deterministic jittering only in the case of multiple collinear points

Fixes:
-  #19
-  #20
-  #50
-  #65
@Fil Fil merged commit 2ee9847 into master Jun 20, 2019
@Fil Fil deleted the degenerate branch July 9, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants