Add d3.geo.project(object, projection). #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given a GeoJSON object (such as a FeatureCollection), returns a new object of the same type with the coordinates projected using the specified projection. The projection is applied by using a buffering output context, and thus incorporates adaptive resampling and clipping, if any.
|
Nice! I fixed a problem with polygon rings. |
D3 doesn't emit a closing point for polygon rings, so this needs to be reinserted since it is required by GeoJSON. If there are fewer than 3 points emitted, then we reinsert the first point more than once, which TopoJSON also does. Alternatively, we might consider generating a line or a point in this situation.
Also, remove the dependency on all for the test target.
|
Thanks for the test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given a GeoJSON object (such as a FeatureCollection), returns a new object of the same type with the coordinates projected using the specified projection. The projection is applied by using a buffering output context, and thus incorporates adaptive resampling and clipping, if any.