Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt type=module #208

Merged
merged 10 commits into from
Jun 11, 2021
Merged

Adopt type=module #208

merged 10 commits into from
Jun 11, 2021

Conversation

Fil
Copy link
Member

@Fil Fil commented Apr 27, 2021

follow changes in d3-format:

  • type=module
  • add exports
  • remove zip
  • license: ISC
  • update dependencies

TODO:

  • update README.md
  • check LICENSE
  • check CLI
  • compare-image and compute-scale
  • depends on d3-geo@3
  • switch the default branch to main
follow changes in d3-format:
* type=module
* add exports
* remove zip
* license: ISC
* update dependencies
@mbostock
Copy link
Member

I rewrote the d3-geo snapshot tests to use pixelmatch, and it seems to work well:

d3/d3-geo@356d26f

Do you want to take a crack at updating this PR to match? (And adding the .github/eslint.json, updating the rollup.config.js to extract the copyright from the LICENSE, upgrading the dependencies, using named imports in the tests, etc.)

The biggest question in my mind right now is how the CLI will work in a pure ES modules environment, given that geoproject currently takes a -r argument to require a library (e.g., d3-geo-polygon). I think we can just use dynamic import (e.g., import("d3-geo-polygon"))… but I haven’t tested that approach yet.

@mbostock mbostock merged commit 29329a6 into main Jun 11, 2021
@mbostock mbostock deleted the fil/type-module branch June 11, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants