*selection*.selection() returns itself #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
append a DIV element to paragraph is not valid HTML https://stackoverflow.com/questions/10763780/putting-div-inside-p-is-adding-an-extra-p https://www.w3docs.com/learn-html/html-div-tag.html
Update README.md
|
transition.selection is used to distinguish a transition from a selection in d3-axis. |
|
We have the case in:
If I'm not mistaken, in axis and zoom what we want is the selection, so using selection.selection() without checking would work in both cases (the code would only get simpler). The only place where it's an issue is in brush, where we would have to find another way to test (maybe check for the |
|
Ah, you’re right. d3-axis and d3-zoom do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #238
"demo" (or rather, playground) at https://observablehq.com/d/a722404aa28e9fc9