Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept iterables. #153

Merged
merged 18 commits into from
Aug 19, 2020
Merged

Accept iterables. #153

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
9d7c3c2
Allow stack.{keys,order} to be iterable.
mbostock Nov 19, 2019
5a4e792
Accept iterable for stack.
mbostock Nov 19, 2019
32221b2
Rename.
mbostock Nov 19, 2019
3c9bd9e
Allow stack.keys function to return an iterable.
mbostock Nov 19, 2019
e3337dd
Allow stack.order function to return an iterable.
mbostock Nov 19, 2019
061a6a5
Allow pie, line, and area to take iterables.
mbostock Nov 19, 2019
3672c01
Test for pie(iterable).
mbostock Nov 19, 2019
7651a1a
links to d3v6 versions
Fil Jul 10, 2020
4364ddc
note about iterables
Fil Jul 10, 2020
42c1493
d3.line(x,y) and d3.are(x,y0,y1) shorthand notations
Fil Jul 17, 2020
4501d87
document shorthand notation and ES6
Fil Jul 17, 2020
d46aac5
shorthand notation symbol(type, size)
Fil Jul 20, 2020
876ab96
symbol(type, size) shorthand
Fil Jul 27, 2020
587bb39
d3.line(x,y) and d3.area(x,y0,y1) shorthand notations
Fil Jul 27, 2020
d12c4f7
yarn.lock
Fil Jul 27, 2020
3683fb8
v2.0.0-rc.1
Fil Jul 27, 2020
696ae24
reactivate tests
Fil Aug 19, 2020
b490be6
documentation links
Fil Aug 19, 2020
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Allow stack.{keys,order} to be iterable.
  • Loading branch information
@mbostock
mbostock committed Nov 19, 2019
commit 9d7c3c2adbf9eccb9e4bab4cd375186de90a1c11
5 changes: 2 additions & 3 deletions src/stack.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import {slice} from "./array.js";
import constant from "./constant.js";
import offsetNone from "./offset/none.js";
import orderNone from "./order/none.js";
Expand Down Expand Up @@ -38,15 +37,15 @@ export default function() {
}

stack.keys = function(_) {
return arguments.length ? (keys = typeof _ === "function" ? _ : constant(slice.call(_)), stack) : keys;
return arguments.length ? (keys = typeof _ === "function" ? _ : constant(Array.from(_)), stack) : keys;
};

stack.value = function(_) {
return arguments.length ? (value = typeof _ === "function" ? _ : constant(+_), stack) : value;
};

stack.order = function(_) {
return arguments.length ? (order = _ == null ? orderNone : typeof _ === "function" ? _ : constant(slice.call(_)), stack) : order;
return arguments.length ? (order = _ == null ? orderNone : typeof _ === "function" ? _ : constant(Array.from(_)), stack) : order;
};

stack.offset = function(_) {
Expand Down